Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spooky October Bugfix #587

Merged
merged 7 commits into from
Oct 29, 2021
Merged

Spooky October Bugfix #587

merged 7 commits into from
Oct 29, 2021

Conversation

aaronbell
Copy link
Collaborator

@aaronbell aaronbell commented Oct 22, 2021

Summary of the Pull Request

This is a fairly comprehensive πŸ›πŸ’€ update resolving many open issues.

PR Checklist

  1. Arabic bugfixes

Screen Shot 2021-10-22 at 9 15 47 AM

Screen Shot 2021-10-22 at 9 14 04 AM

Also:
#543 - uni0615 removed as Cascadia Arabic not intended to support Quranic

  1. Other bug fixes

Screen Shot 2021-10-22 at 9 13 02 AM

  • Closes == Ligature not workingΒ #436 πŸ§Ÿβ€β™€οΈ - Extended length of Powerline 'caps' to avoid situations where rounding can prevent overlap. This may cause problems if the caps are used next to one another, but that seems an unlikely scenario given what I've reviewed of Powerline styles.

Screen Shot 2021-10-22 at 9 17 34 AM

Screen Shot 2021-10-22 at 9 19 52 AM

Screen Shot 2021-10-22 at 9 20 25 AM

Screen Shot 2021-10-22 at 9 20 58 AM

Screen Shot 2021-10-22 at 9 22 40 AM

aaronbell and others added 7 commits October 22, 2021 08:49
1) Re-implements the CALT issue wherein LIG GSUB wouldn't work (this was lost during the fix.

2) Changes the STAT table generation library from statmake to gftools.stat, and all other necessary fixes.
removing "Medium" weight.
This update is primarily a bugfix update with improvements to Arabic as well as a variety of other small bugs / requests from the community.

Another additional change is coming.
Forgot to add a couple of finals :/
@DHowett
Copy link
Member

DHowett commented Oct 28, 2021

As always, I love it. Thanks!

I might brand this 2110.30 and call it the actual halloween release πŸ˜„

@@ -32,7 +32,7 @@
<key>x</key>
<integer>886</integer>
<key>y</key>
<integer>-20</integer>
<integer>-1040</integer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these guideline changes aren't anything to worry about, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah. That's just a guideline. Won't affect anything.

@DHowett DHowett merged commit 8881170 into microsoft:main Oct 29, 2021
@DHowett
Copy link
Member

DHowett commented Oct 29, 2021

Woot! Thanks!

@aaronbell
Copy link
Collaborator Author

Seeing all those issues close at once is happy happy πŸ˜„ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment