July-August 2021 Fixes (#538) #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary of the Pull Request This includes two fixes: - [x] Closes #500 Changes the build process to use gftools.stat instead of statmake. The issue was caused by an 'unused' italic axis in the fonts, which has been removed, but statmake gets unhappy without it there. So the process has been adjusted to a more amenable build library. - [x] Closes #552 Adds the Hebrew language tag to the Regular to ensure that Hebrew positioning works correctly. Also: Adjusts calt feature to ensure LIG substitutions properly function under rare conditions where the `ignore` activate incorrectly. I thought this had already been PR'd but seems not. For example: `===]` First = becomes "equal_equal.liga", and ignore would activate on second =, blocking LIG from being substituted. If the liga form appears, LIG should appear. Turned back on the =>> =<<, etc. ligatures as there is a glyph for them now.
**The problem** The code had a case of a manual file handler pitfall, where a resource stream is opened manually and never closed. This pitfall was detected using Pyling, which triggered a message of code R1732 with the content "Consider using 'with' for resource-allocating operations" **The solution** Used a 'with' block to automatically close the open stream on the file just after it is no longer needed
This is a fairly comprehensive (and spooky!) 🐛💀 update resolving many open issues. ### Arabic bugfixes - [x] Closes #532 👻 - Additional positional variants added - [x] Closes #535 🍂 - Corrected hamza form - [x] Closes #540 🎃 - Dot arrangement corrected - [x] Closes #541 🧹 - Was due to the use of anchors on those glyphs. These have been removed so the glyph can render as spacing. - [x] Closes #542 🌕 - This was partly due to a [bug in Harfbuzz]. It has been resolved both on the font side (through a different implementation) and in Harfbuzz. - [x] Closes #549 🦸♀️ - Design corrected - [x] Closes #555 💀 - All letter glyphs removed from Arabic Presentation form unicode slots to avoid situations where the glyphs are not behaving as expected. - [x] Related to #543 - uni0615 removed as Cascadia Arabic not intended to support Quranic ### Other bug fixes - [x] Closes #488 🔪 - Finally made the www ligature have the proper number of `w`s. - [x] Closes #436 🧟♀️ - Extended length of Powerline 'caps' to avoid situations where rounding can prevent overlap. This may cause problems if the caps are used next to one another, but that seems an unlikely scenario given what I've reviewed of Powerline styles. - [x] Closes #521 🤖 - enlarged the size of the grave character to make it more recognizable / legible in code. - [x] Closes #524 ☠️ - Added some more differentiation in stroke, and also created more space using hinting. - [x] Closes #525 🧙♂️ - tweaked the braces to be more twisty and create better differentiation from the parens. - [x] Closes #529 🧛♀️ - Changed year :P - [x] Closes #546 👹 - ij no longer masquerading as a mark. - [x] Closes #563 🧟♂️ - corrected `locl` feature for proper Serbian rendering - [x] Closes #571 🦹♀️ - corrected overshoot - [x] Closes #572 🕷 - ratio symbol added - [x] Closes #577 🍁 - shifted heights of box drawing lines to better align with block glyphs. Will reduce risk of non-joining forms under certain conditions. [bug in harfbuzz]: harfbuzz/harfbuzz#3069 (comment)
When I updated the brace character, it appeared that the italic versions were rendering correctly. However, that was incorrect... They are rendering correctly now. Closes #595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This includes two fixes:
Closes [Question] How can I use only light and light italic by default in vscode? microsoft/cascadia-code#500
Changes the build process to use gftools.stat instead of statmake. The issue was caused by an 'unused' italic axis in the fonts, which has been removed, but statmake gets unhappy without it there. So the process has been adjusted to a more amenable build library.
Closes U+05B9 HEBREW POINT HOLAM is positioned wrong on U+05D5 HEBREW LETTER VAV microsoft/cascadia-code#552
Adds the Hebrew language tag to the Regular to ensure that Hebrew positioning works correctly.
Also:
Adjusts calt feature to ensure LIG substitutions properly function under rare conditions where the
ignoreactivate incorrectly. I thought this had already been PR'd but seems not.For example:
===]First = becomes "equal_equal.liga", and ignore would activate on second =, blocking LIG from being substituted. If the liga form appears, LIG should appear.
Turned back on the =>> =<<, etc. ligatures as there is a glyph for them now.
Summary of the Pull Request
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Before (if applicable) and After Images of the Character(s)
Validation Steps Performed