Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import document tool to new auth model #239

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

gitri-ms
Copy link
Collaborator

Motivation and Context

The recent changes to the authentication model in Chat Copilot effiectively broke the import document tool. This change fixes it, by enabling users to:

  • Use the tool with an unauthenticated local instance of Chat Copilot without signing in
  • Use the tool with an Azure-deployed instance of Chat Copilot with Azure AD authentication enabled

Fixes #212, fixes #231

Description

  • Adds code paths to authenticate user (or not) depending on configuration
  • Removes user name/info from document import form
  • Updates README with instructions for setting up the app registration for import document tool and configuring appsettings.json

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines and the pre-submission formatting script raises no violations
  • All unit tests pass, and I have added new tests where possible - N/A, but both supported scenarios have been tested
  • I didn't break anyone 😄

@gitri-ms gitri-ms self-assigned this Aug 23, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation PR: ready for review labels Aug 23, 2023
@gitri-ms gitri-ms added this pull request to the merge queue Aug 23, 2023
Merged via the queue into microsoft:main with commit 3838fca Aug 23, 2023
6 checks passed
@gitri-ms gitri-ms deleted the import-doc-tool branch August 23, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
2 participants