-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
having both SPA
and mobile and desktop
redirect URIs leads to an error
#212
Comments
Thank you for this question. We are always looking to improve our deployment documentation and process. I will follow-up after looking into this. |
Yes please let me know if you need anything from my side |
Hi @ekdnam, I believe the solution here is that you need two separate app registrations: one for Chat Copilot that uses the SPA platform type, and another for the import document tool that uses the Mobile/Desktop platform type. (As you've seen, trying to combine the two causes problems with token redemption in Chat Copilot.) I will update the README to make this clearer. |
### Motivation and Context The recent changes to the authentication model in Chat Copilot effiectively broke the import document tool. This change fixes it, by enabling users to: - Use the tool with an unauthenticated local instance of Chat Copilot without signing in - Use the tool with an Azure-deployed instance of Chat Copilot with Azure AD authentication enabled Fixes #212, fixes #231 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - Adds code paths to authenticate user (or not) depending on configuration - Removes user name/info from document import form - Updates README with instructions for setting up the app registration for import document tool and configuring appsettings.json ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - N/A, but both supported scenarios have been tested - [x] I didn't break anyone 😄
### Motivation and Context The recent changes to the authentication model in Chat Copilot effiectively broke the import document tool. This change fixes it, by enabling users to: - Use the tool with an unauthenticated local instance of Chat Copilot without signing in - Use the tool with an Azure-deployed instance of Chat Copilot with Azure AD authentication enabled Fixes microsoft#212, fixes microsoft#231 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - Adds code paths to authenticate user (or not) depending on configuration - Removes user name/info from document import form - Updates README with instructions for setting up the app registration for import document tool and configuring appsettings.json ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - N/A, but both supported scenarios have been tested - [x] I didn't break anyone 😄
Describe the bug
A clear and concise description of what the bug is.
I followed both the Azure Active Directory app registration procedures as stated in ./README.md and ./tools/importdocument/README.md.
Specifically:
From
./README.md
and
./tools/importdocument/README.md
If there are both, it leads to the error
However if I remove the Mobile and desktop applications redirect URI and just keep SPA, the app works fine.
How to resolve?
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Platform
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: