Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production release, runs the command cordova build #392

Closed
srameshr opened this issue Feb 9, 2017 · 2 comments
Closed

Production release, runs the command cordova build #392

srameshr opened this issue Feb 9, 2017 · 2 comments
Assignees
@max-mironov
Labels
enhancement

Comments

@srameshr
Copy link

srameshr commented Feb 9, 2017 

code-push release-cordova my_app ios -t 1.2.0  --description "Test" --build  deploymentName Production

This command runs cordova build ios and not cordova build ios --release
@max-mironov max-mironov self-assigned this Feb 9, 2017
max-mironov pushed a commit to max-mironov/code-push that referenced this issue Mar 6, 2017
Add ability to specify build type for Cordova
3aae97d 
Also fixes issue microsoft#392
@max-mironov max-mironov mentioned this issue Mar 6, 2017
Merged
max-mironov pushed a commit that referenced this issue Mar 10, 2017
Add build type option to release cordova command (#409)
89cbef2 
* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, microsoft/react-native-code-push#723, microsoft/react-native-code-push#717

* Add ability to specify build type for Cordova
Also fixes issue #392

* revert changes not related to this PR

* Minor tweak for readme

* Reordered param names for cordova-release command in Readme alphabetically
@max-mironov
Copy link
Contributor

Hello @srameshr, we have implemented this in #409.
Closing this for now, please let us know if you see any issues or have any questions.

@gs-sramesh
Copy link

@max-mironov Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@max-mironov max-mironov

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sergey-akhalkov @srameshr @gs-sramesh @max-mironov