-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate integration with pydevd that has the sys.monitoring changes #1640
Comments
Did some preliminary work on this. I'm not sure pydevd is finished with sys.monitoring support. We get about 50 test failures with py312 (py311 and others work fine) after the port. |
Root cause of failures seems to be 3.12 pydevd doesn't handle unhandled exceptions. In 3.11 for one of the tests that fails, this output shows up in the log:
Same test in 3.12, no such post-mortem stop |
Question then becomes do we integrate newer pydevd or just finish the sys.monitoring work for 3.12 in debugpy. |
This test and many others is failing currently in our implementation of sys.monitoring, so pydevd is likely further along. |
Consensus was to scrap this work (archived at https://github.com/rchiodo/debugpy/tree/rchiodo/update_pydevd) and just finish the debugpy work on 3.12 |
Changed our minds again. Going to integrate latest pydevd. |
First reason for failure, stack frames on attach are deeper than launch. Not sure why (I don't think sys module would know about filtering out just my code?). Deeper stack frame means the frame matching for the unhandled exception walk doesn't work. |
Finished this work |
No description provided.
The text was updated successfully, but these errors were encountered: