Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min/max/close stay on what system theme was at launch #1858

Open
mathewleeza opened this issue Nov 10, 2023 · 1 comment
Open

Min/max/close stay on what system theme was at launch #1858

mathewleeza opened this issue Nov 10, 2023 · 1 comment
Assignees
@krschau
Labels
Area-Core Related to Dev Home as a whole 🏠 Issue-Bug Something isn't working or needs investigation Priority-2 Type-Style Related to UI design, theming issues

Comments

@mathewleeza
Copy link
Contributor

Dev Home version

No response

Windows build number

No response

Other software

image

Steps to reproduce the bug

Min/max/close have incorrect theming when in dark theme

Expected result

No response

Actual result

Min/max/close have incorrect theming when in dark theme

Included System Information

No response

Included Extensions Information

No response
@mathewleeza mathewleeza added Priority-1 Type-External Related to a feature outside this repository labels Nov 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Nov 10, 2023
@mathewleeza mathewleeza added the Area-Core Related to Dev Home as a whole 🏠 label Nov 10, 2023
@krschau krschau mentioned this issue Nov 13, 2023
Closed
@krschau krschau removed the Needs-Triage New issue that the core contributors need to triage label Dec 6, 2023
@krschau krschau added Issue-Bug Something isn't working or needs investigation Priority-2 and removed Priority-1 Type-External Related to a feature outside this repository labels Feb 1, 2024
@krschau krschau added the Type-Style Related to UI design, theming issues label Mar 18, 2024
@krschau
Copy link
Collaborator

krschau commented May 14, 2024

Behavior I'm seeing on 0.14 canary:

  1. System theme dark, DH theme dark, icons are good. Change DH theme to light, icons don't update
  2. System theme dark, DH theme light, icons are using dark theme. Change DH theme to dark and the icons now look right.

@krschau krschau changed the title Min/max/close have incorrect theming when in dark theme Min/max/close stay on what system theme was at launch May 14, 2024
@krschau krschau mentioned this issue May 14, 2024
Closed
@krschau krschau self-assigned this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krschau krschau

Labels
Area-Core Related to Dev Home as a whole 🏠 Issue-Bug Something isn't working or needs investigation Priority-2 Type-Style Related to UI design, theming issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krschau @mathewleeza