Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Translation #785

Open
Tracked by #3690
XHQ6666 opened this issue May 24, 2023 · 5 comments
Open
Tracked by #3690

Chinese Translation #785

XHQ6666 opened this issue May 24, 2023 · 5 comments
Assignees
Labels
Area-Core Related to Dev Home as a whole 🏠 Issue-Translation There is a problem with a translation

Comments

@XHQ6666
Copy link

XHQ6666 commented May 24, 2023

Dev Home version

0.137.141.0

🌐 Language

简体中文

❌ Actual phrase(s)

image image image

✔️ Expected phrase(s)

SSH 密钥链 (SSH Keychain)
内存 (Memory)
网络 (Network)
请求审查 (Review requested)
问题 (Issues)
拉取请求 (Pull requests)
提及我 (Mentioned me)
指派给我的 (Assigned to me)
设置开发环境 (Set up development environment)
新建报告 (New report)
新增建议 (New suggestion)
报告一个翻译问题 (Report a translation problem)

Why is the current translation wrong

Incomplete translation to Simplified Chinese.

@XHQ6666 XHQ6666 added the Issue-Translation There is a problem with a translation label May 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label May 24, 2023
@Melendez1209
Copy link

Maybe I can do it!

@Melendez1209
Copy link

Melendez1209 commented May 24, 2023

@cinnamon-msft I have a question. I can't find any files other than en-us for storing the localization language data in an address other than the build folder. Where can I change these? And how do they show up in the app?

@XHQ6666
Copy link
Author

XHQ6666 commented May 24, 2023

@cinnamon-msft I have a question. I can't find any files other than en-us for storing the localization language data in an address other than the build folder. Where can I change these? And how do they show up in the app?

Me too, I'm not quite sure how it implements displaying other languages.

@florelis
Copy link
Member

florelis commented May 24, 2023

For a bit of context about localization in this app (assuming it's the same as in other MS apps):

There is a build pipeline that picks up the en-us file and submits it to the localization team. They have some system where they enter the translations and relate them to the string IDs used in the en-us file. Then, another build pipeline sends a request to the localization service to get the translated resources. I assume that's only done in the release pipeline, so they never make it to this repo.

It would be possible to add the translated files here to make it easier to submit issues, but still we can't just merge those PRs. Instead, we would have to forward the PRs to the loc team, have them consider it, and if they like it, update the strings on their systems. Then it would make it back here eventually.

BTW, sometimes the translation errors come from a lack of adequate comments in the original en-us file. If you think it's something that could be resolved by a comment, i think that would be better since it would prevent the issue in other languages too. For example, if a word is ambiguous like "run" that could be "a run" or "running", we can add a comment "this is a noun/verb".

Edit: See #808

@Melendez1209
Copy link

OK, fine. It's not exactly what I expected. The appropriate translation is already at the top. I'm also working on a Winui app recently. As an individual developer, I don't think this approach of requiring a translation team works for me. Do you have any other suggestions?The project

@mathewleeza mathewleeza added Area-Core Related to Dev Home as a whole 🏠 and removed Needs-Triage New issue that the core contributors need to triage labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Core Related to Dev Home as a whole 🏠 Issue-Translation There is a problem with a translation
Projects
None yet
Development

No branches or pull requests

5 participants