This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
The HyperLinks to About and Privacy docs on Portability Analyzer Setting are not navigatable #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Analyzer Setting are not navigatable
twsouthwick
approved these changes
Jun 11, 2019
| @@ -186,7 +186,7 @@ | |||
|
|
|||
| <TextBlock Grid.Column="2" | |||
| HorizontalAlignment="Right"> | |||
| <Hyperlink RequestNavigate="NavigateToMoreInformation" | |||
| <Hyperlink NavigateUri="DocumentationLinks.About" RequestNavigate="NavigateToMoreInformation" | |||
There was a problem hiding this comment.
Is this needed? Looks like you either need to set the uri or could consolidate the event handlers
There was a problem hiding this comment.
Yes, adding the uri actually fixed the original problem. Looks like consolidate the event handler only is not enough.
|
If you reference the issue in the body of the PR, it'll create a link. ie |
twsouthwick
changed the title
|
And if you say |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Analyzer Setting are not navigatable