Move filter delete auditing to delete notify callback #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dv-msft
changed the title
dv-msft
force-pushed
the
3370-filter-delete-audit-fix
branch
from
3f9fdfa
to
6081704
Compare
dv-msft
changed the title
dv-msft
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
dv-msft
force-pushed
the
3370-filter-delete-audit-fix
branch
from
6d7ed4a
to
d48e436
Compare
shankarseal
approved these changes
Mar 22, 2024
gtrevi
approved these changes
Mar 22, 2024
shankarseal
added a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Mar 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 30, 2024
* extension_header * fix logic error. * Re-purposing the size field to act as the "minor version". Additional validation checks are added. * PR Feedback. * fix break due to bad merge with PR #3372
shankarseal
added a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Apr 1, 2024
* extension_header * fix logic error. * Re-purposing the size field to act as the "minor version". Additional validation checks are added. * PR Feedback. * fix break due to bad merge with PR microsoft#3372
matthewige
pushed a commit
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the audit tracking of filter delete operations to the 'filter-update' notification callback. This call back is the final indicator of a filter being actually deleted by WFP.
Testing
Local testing.
Documentation
No documentation changes required.
Installation
No installer impac.
Fixes #3370