Added the checkbox component #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janechu
requested review from
williamw2,
nicholasrice and
EisenbergEffect
as code owners
EisenbergEffect
approved these changes
May 19, 2022
<!--- Provide some background and a description of your work. --> Adds the number-field foundation component. Also applied a small cleanup to some of the component testing. <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
force-pushed
the
users/janechu/add-checkbox-component
branch
from
63f19f1
to
8e1d02a
Compare
3 tasks
janechu
added a commit
that referenced
this pull request
May 23, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This work moves the individual playwright tests to their own files and leverages the setup from #53 so that temp files have their own uuid. Edit: This may seem like a lot of duplication, but I believe it is preferable to attempting to optimize too soon as we don't yet know what extra component-specific tests will be required. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## 👩💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. --> No changes, only file moves. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue work on #31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the checkbox foundation component.
Also moved some helper files for the component testing to a separate file and moved a component test to the components folder.
Continues work on #31