Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the tests into individual files for parallelization #54

Merged
merged 7 commits into from
May 23, 2022

Conversation

janechu
Copy link
Contributor

@janechu janechu commented May 20, 2022

Pull Request

πŸ“– Description

This work moves the individual playwright tests to their own files and leverages the setup from #53 so that temp files have their own uuid.

Edit: This may seem like a lot of duplication, but I believe it is preferable to attempting to optimize too soon as we don't yet know what extra component-specific tests will be required.

🎫 Issues

Continues work on #31

πŸ‘©β€πŸ’» Reviewer Notes

No changes, only file moves.

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.

⏭ Next Steps

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the hope to see a refactor at a not too distant point. One thing you can do is keep a file per component but have them import the shared test functions to just pass to the test helper. In that way they can share what they need and still have component-specific tests and custom test names.

@janechu
Copy link
Contributor Author

janechu commented May 23, 2022

Approving with the hope to see a refactor at a not too distant point. One thing you can do is keep a file per component but have them import the shared test functions to just pass to the test helper. In that way they can share what they need and still have component-specific tests and custom test names.

Can do, I refactored out a bunch of things into a helper test file already so I can certainly put that to work in a new PR to cut down on some of this.

@janechu janechu merged commit 0142cb5 into main May 23, 2022
@janechu janechu deleted the users/janechu/move-tests branch May 23, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants