Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: when script option is turned on, enable custom script to run benchmarks #6110

Closed
prudepixie opened this issue Jun 14, 2022 · 2 comments
Assignees
Labels
closed:obsolete No longer valid

Comments

@prudepixie
Copy link
Contributor

prudepixie commented Jun 14, 2022

Following the script that was created under the Repeat benchmark, there needs to be a way to run the script that compiles the JSON object that the script reads into a table that is more readable.

Tracking work here https://github.com/microsoft/fast/tree/users/wendy/custom-script

  • There is a PR in tachometer where you can turn on 'collate' and it would filter the table to separate tables for better readability of the results, so to achieve this with my script, I currently have to symlink to that PR/branch
  • The next task around this work is to figure out a 'base suite' of benchmarks that would be able to test Repeat holistically.
    -----------Update-----------------------------

Currently, each 'configuration' is generated to a unique url that is passed into the benchmarks array (for tachometer config), and the entryName under measurement all point to the same operation

"url": "dist/fast-element_repeat-clickTrigger10x.html?template=basic&method=reverse&loopCount=1&itemCount=500",
...
  "measurement": [
        {
          "mode": "performance",
          "entryName": "clickTrigger10x"
        },
        {
          "name": "usedJSHeapSize",
          "mode": "expression",
          "expression": "window.usedJSHeapSize"
        }
      ]

another possible approach is to create unique entryNames under the measurement array (for tachometer config):

  "measurement": [
        {
          "mode": "performance",
          "entryName": "reverse"
        },
        {
         "mode": "performance",
          "entryName": "push"
        },
       {
         "mode": "performance",
          "entryName": "shift"
        }
      ]
@prudepixie
Copy link
Contributor Author

This work is moved back to backlog, as this works locally, but to merge into the main branch, would have to wait until the collate PR gets merged to tachometer.

@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Benchmarks have been redone to use the tensile perf package see #6968. As such this issue is no longer valid.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu removed this from the FAST Element 2.0 milestone May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:obsolete No longer valid
Projects
None yet
Development

No branches or pull requests

2 participants