Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate benchmarks pipeline failing, wrong ChromeDriver version #6637

Closed
prudepixie opened this issue Feb 13, 2023 · 1 comment
Closed
Assignees
Labels
closed:obsolete No longer valid status:triage New Issue - needs triage

Comments

@prudepixie
Copy link
Contributor

prudepixie commented Feb 13, 2023

🐛 Bug Report

ChromeDriver is a tachometer dependency package, this should be auto installed when benchmarks are triggered since ChromeDriver is not included in fast-benchmarks's package.json as a dev dependency.

Latest version of Chrome needs to be installed along with ChromeDriver
However, it seems like the version that is being auto installed in the pipeline is not up to date.

I have manually disabled this workflow for now until this issue is resolved.

💻 Repro or Code Sample

In github actions file, 'Run Tachometer' step

Package "chromedriver@* installed."
SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 110
Current browser version is 109.0.5414.119 with binary path /usr/bin/google-chrome

🤔 Expected Behavior

Benchmarks to run and no errors in valid benchmarks pipeline

😯 Current Behavior

validate benchmarks pipeline failing

💁 Possible Solution

One potential fix is to include an extra step in the pipeline to 1) check for Chrome version 2) install latest Chrome version

🔦 Context

🌍 Your Environment

  • OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
  • Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
  • Version [e.g. 1.8.0]
@prudepixie prudepixie added the status:triage New Issue - needs triage label Feb 13, 2023
@prudepixie prudepixie self-assigned this Feb 13, 2023
@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Benchmarking has been moved to use tensile perf as of #6968 and this no longer an issue.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:obsolete No longer valid status:triage New Issue - needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants