Remove benchmark package #6968
Merged
Remove benchmark package #6968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janechu
requested review from
chrisdholt,
awentzel,
Falkicon and
radium-v
as code owners
chrisdholt
approved these changes
May 23, 2024
KingOfTac
approved these changes
May 23, 2024
9 tasks
This was referenced May 29, 2024
janechu
added a commit
that referenced
this pull request
Jun 10, 2024
# Pull Request ## 📖 Description This change removes `@microsoft/fast-benchmarks` and instead leverages the `@tensile-perf/web-components` package for local perf testing. ### 🎫 Issues Resolves #6949 ## 👩💻 Reviewer Notes This makes a best effort at re-creating benchmarking done between the two methods of benchmarking. All results are still local only and are not published anywhere. That may be a future piece of work so that results may be published and used as part of a build gate workflow. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have included a change request file using `$ yarn change` - [x] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](/docs/community/code-of-conduct/#our-standards) for this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This change removes
@microsoft/fast-benchmarksand instead leverages the@tensile-perf/web-componentspackage for local perf testing.🎫 Issues
Resolves #6949
👩💻 Reviewer Notes
This makes a best effort at re-creating benchmarking done between the two methods of benchmarking. All results are still local only and are not published anywhere. That may be a future piece of work so that results may be published and used as part of a build gate workflow.
✅ Checklist
General
$ yarn change