Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async implementation of TryGetAsync on ISessionManager not possible? #38

Closed
hansmbakker opened this issue Dec 19, 2019 · 1 comment · Fixed by #51
Closed

async implementation of TryGetAsync on ISessionManager not possible? #38

hansmbakker opened this issue Dec 19, 2019 · 1 comment · Fixed by #51
Assignees
@jimmyca15

Comments

@hansmbakker
Copy link

The ISessionManager interface switched to using an async approach, which is good in itself.

However the TryGetAsync function uses an out parameter which forbids declaring the function as async - so you cannot await Tasks in the function body.

This feels a bit awkward - do you have any example on how to best tackle that?
@jimmyca15
Copy link
Member

This is definitely a problem and needs to be addressed in the next release. An oversight in the transition to async.

@jimmyca15 jimmyca15 self-assigned this Dec 19, 2019
@jimmyca15 jimmyca15 mentioned this issue Feb 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmyca15 jimmyca15

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hansmbakker @jimmyca15