Addresses issue with delete CustomSearch parameter, adds back one ValidateTest #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 89ae3f3 into de6e518 - view on LGTM.com new alerts:
|
Ivanidzo4ka
reviewed
Aug 2, 2021
| updated.Add(param); | ||
| updated.Add(param); | ||
| } | ||
| else if (!updatedSearchParameterStatus.Where(p => p.Uri.Equals(paramStatus) && p.Status == SearchParameterStatus.Deleted).Any()) |
There was a problem hiding this comment.
Nit: I think this could also be simplified to
else if (!updatedSearchParameterStatus.Any(p => p.Uri.Equals(paramStatus.Uri) && p.Status == SearchParameterStatus.Deleted))
rotodd
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses the delete failure with CustomSearch parameters. Adds back one missing test case on Validate tests
Related issues
Addresses [issue AB#82428].
Testing
Reran the branch against CI environment
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)
Skip