fix rotation bug on segmented control #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwilkes
approved these changes
Nov 30, 2022
huwilkes
pushed a commit
to huwilkes/fluentui-apple
that referenced
this pull request
Dec 1, 2022
11 tasks
huwilkes
added a commit
that referenced
this pull request
Dec 1, 2022
huwilkes
pushed a commit
to huwilkes/fluentui-apple
that referenced
this pull request
Dec 5, 2022
11 tasks
huwilkes
added a commit
that referenced
this pull request
Dec 15, 2022
* fix rotation bug on segmented control (#1411) * Fix pillMaskedLabelContainerView comment * Fix update logic * Make tokenSink and animation duration private * Update selectionView on token update Co-authored-by: Harrie Shin <hyshin@microsoft.com>
edjamesmsft
added a commit
that referenced
this pull request
Jan 25, 2023
* SegmentedControl code clean up (#1432) * fix rotation bug on segmented control (#1411) * Fix pillMaskedLabelContainerView comment * Fix update logic * Make tokenSink and animation duration private * Update selectionView on token update Co-authored-by: Harrie Shin <hyshin@microsoft.com> * Update to checkout v3 (#1459) * Adding additional leading view to TableViewCell (#1446) * Merge tokenized Tooltip into main (#1434) * Bring Tooltip to main * remove extra space * Bring changes from theming fix * [XCUITests] Launch tests for all controls (#1461) * add launch tests * remove test template * update to use base class + resolve comments * change back to swift + use extension * change back to base class with overridden control name * resolve comments * Add documentation for Avatar (#1469) * add documentation for avatar * add swiftui usage example * Add documentation for Button (#1471) * Added button documentation * Fix table in documentation * Fix table * Rename table sections + fix path and typo * Resized documentation images * Cleanup * More cleanup * Added names to documentation * fix tooltip png filenames (#1473) * Update Date Picker test to start from `now` to fix test failure (#1477) * Update Date Picker test to start from today * Add explicit type interface * Create a Readme section for demo app controls (#1268) * Added new readme icon * Added a vc for the readme * Created scroll view and labels * Added a ReadmeStrings class * Removing title + polishing readme class * Added a few more readmes * Revert "Added new readme icon" This reverts commit c73665f. * Moving constant values into a struct * Moved strings to their respective demo controllers * Change from readme button text to icon * Added todo to change color to fluent 2 ramp * Moved constants struct to top of the file * Use NSLayourConstraint.activate * Added tvc readme section * Removed unnecessary function * Make fields private * Refactor + added a few readmes * Added more readmes * Cleanup * Move constraints logic to viewDidLoad * Moved private properties to bottom of file * Change unavailable to unavailable (#1475) * Centralize missing readme string (#1479) * [XCUITests] Add macOS launch tests (#1484) * add macos launch tests * try adding to ci * remove other build commands * change arch * change macOS version * add back build commands * Resolving height issue (#1485) * [XCUITests] Add iOS XCUITests to CI (#1480) * test adding ios tests to ci * remove -ios * try changing to Demo.Development * add new scheme * add executable to run * check run * uncheck run * change back to Demo.Development * remove scheme * change to just test * add back scheme * remove other build commands * add back debug build * add test retries * comment out non tokenized tests * remove retries + turn off parallelism * add back other tests * test if all are going to command bar * change tests back to controlName * add tear down that deletes app * remove setup logic * add timeouts * change timeout to 1 * add back other build commands * remove scheme * whitespace change * update tearDown to use isFirstLaunch * fix linting issue * remove isFirstLaunch from UserDefaults and add #if DEBUG * try moving navigation back to setUpWithError * whitespace change * Skip failing date picker tests (#1495) * Fix BadgeField space bug (#1497) * attempt to fix space bug * add comment * [XCUITests] Activity Indicator tests (#1493) * initial activity indicator tests * add transition to dark mode * whitespace change * add dark mode color assert * add default color to identifier * update comment * add dark mode + update to use .* * add #if DEBUG * add #if DEBUG to SceneDelegate * add constants * add type * change to hex code * removing color tests * Revert "removing color tests" This reverts commit 79c20c0. * removing color tests again * remove SceneDelegate change * small change * make code more readable + have SwiftUI inherit from UIKit * remove super * [XCUITests] Indeterminate Progress Bar tests (#1503) * add indeterminate progress bar tests * update SwiftUI to inherit from UIKit * remove super * resolve comments * Resolving demo conflicts * Resolving TableViewCell merge conflicts * Taking tokenized tooltip from main - no fluent2 * Getting TVC building again * Updating tooltip tokens * Fixing TVC sample data and demo project * Fixing token values Co-authored-by: huwilkes <67026548+huwilkes@users.noreply.github.com> Co-authored-by: Harrie Shin <hyshin@microsoft.com> Co-authored-by: Sophia Lee <sophia.lee0416@gmail.com> Co-authored-by: Jeanie Huynh <31874971+jeaniehuynh@users.noreply.github.com> Co-authored-by: Joanna Qu <55368679+joannaquu@users.noreply.github.com> Co-authored-by: Lamine Male <106181067+laminesm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
fix 1)
In main branch, segmentedcontrol is re-written with UIStackView so the layout happens correctly.
However, in previous versions, segmentedcontrol buttons were layed out by frame calculation. There is a bug which when segmented control rotates it doesn't layout the pillbutton's title and the mask title correctly.
Workaround for now is to call SetNeedLayout on each button when we set the frame of the buttons during layoutSubviews.
Fix 2)
we should never call layoutsubview() directly. According to apple documentation, if you want to force a layout update, call the setNeedsLayout method instead to do so prior to the next drawing update. If you want to update the layout of your views immediately, call the layoutIfNeeded method.
Fix 3)
remove unused code "intrinsicContentSizeInvalidatedForChildView"
Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow