Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XCUITests] Indeterminate Progress Bar tests #1503

Merged
merged 5 commits into from
Jan 23, 2023
Merged

[XCUITests] Indeterminate Progress Bar tests #1503

merged 5 commits into from
Jan 23, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jan 20, 2023 •
edited
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

Binary change:

File Before After Delta
libFluentUI.a 28,875,336 bytes 28,875,344 bytes 8 bytes

Note: When comparing sizes, libFluentUI.a will show as 28,875,336 bytes on main branch and 28,875,344 bytes on my personal branch. However, once merged, main branch will be as expected (28,875,336 bytes, with 0 bytes delta). This has happened with other other XCUITests PRs as well so although it seems that each test PR increases the binary size, once merged it'll return to 0 bytes delta.

Added new UI test for Indeterminate Progress Bar (both UIKit and SwiftUI). An accessibility identifier was added to IndeterminateProgressBar in debug that tracks the state's status for tests. Specifically, testStartStopHide was added, which tests the start/stop functionality as well as hiding (indeterminate progress bar should disappear when stopped). The SwiftUI test was also updated to inherit from the UIKit test instead of BaseTest to cut down on code duplication.

Verification

UIKit SwiftUI
Simulator Screen Recording - iPhone 14 Pro - 2023-01-19 at 15 29 35 Simulator Screen Recording - iPhone 14 Pro - 2023-01-19 at 15 30 23

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)

@joannaquu joannaquu requested a review from a team as a code owner January 20, 2023 19:26
@joannaquu joannaquu merged commit 8872ab6 into microsoft:main Jan 23, 2023
@joannaquu joannaquu deleted the joannaqu/indeterminate-progress-bar-test branch January 23, 2023 19:12
@joannaquu joannaquu mentioned this pull request Jan 23, 2023
Closed
11 tasks
@edjamesmsft edjamesmsft mentioned this pull request Jan 25, 2023
Merged
11 tasks
edjamesmsft added a commit that referenced this pull request Jan 25, 2023
@edjamesmsft @huwilkes
@harrieshin @sophialee0416 @jeaniehuynh @joannaquu @laminesm
[Fluent 2 iOS] Merge main (#1513)
e42fb1c 
* SegmentedControl code clean up (#1432)

* fix rotation bug on segmented control (#1411)

* Fix pillMaskedLabelContainerView comment

* Fix update logic

* Make tokenSink and animation duration private

* Update selectionView on token update

Co-authored-by: Harrie Shin <hyshin@microsoft.com>

* Update to checkout v3 (#1459)

* Adding additional leading view to TableViewCell (#1446)

* Merge tokenized Tooltip into main (#1434)

* Bring Tooltip to main

* remove extra space

* Bring changes from theming fix

* [XCUITests] Launch tests for all controls (#1461)

* add launch tests

* remove test template

* update to use base class + resolve comments

* change back to swift + use extension

* change back to base class with overridden control name

* resolve comments

* Add documentation for Avatar (#1469)

* add documentation for avatar

* add swiftui usage example

* Add documentation for Button (#1471)

* Added button documentation

* Fix table in documentation

* Fix table

* Rename table sections + fix path and typo

* Resized documentation images

* Cleanup

* More cleanup

* Added names to documentation

* fix tooltip png filenames (#1473)

* Update Date Picker test to start from `now` to fix test failure (#1477)

* Update Date Picker test to start from today

* Add explicit type interface

* Create a Readme section for demo app controls (#1268)

* Added new readme icon

* Added a vc for the readme

* Created scroll view and labels

* Added a ReadmeStrings class

* Removing title + polishing readme class

* Added a few more readmes

* Revert "Added new readme icon"

This reverts commit c73665f.

* Moving constant values into a struct

* Moved strings to their respective demo controllers

* Change from readme button text to icon

* Added todo to change color to fluent 2 ramp

* Moved constants struct to top of the file

* Use NSLayourConstraint.activate

* Added tvc readme section

* Removed unnecessary function

* Make fields private

* Refactor + added a few readmes

* Added more readmes

* Cleanup

* Move constraints logic to viewDidLoad

* Moved private properties to bottom of file

* Change unavailable to unavailable (#1475)

* Centralize missing readme string (#1479)

* [XCUITests] Add macOS launch tests (#1484)

* add macos launch tests

* try adding to ci

* remove other build commands

* change arch

* change macOS version

* add back build commands

* Resolving height issue (#1485)

* [XCUITests] Add iOS XCUITests to CI (#1480)

* test adding ios tests to ci

* remove -ios

* try changing to Demo.Development

* add new scheme

* add executable to run

* check run

* uncheck run

* change back to Demo.Development

* remove scheme

* change to just test

* add back scheme

* remove other build commands

* add back debug build

* add test retries

* comment out non tokenized tests

* remove retries + turn off parallelism

* add back other tests

* test if all are going to command bar

* change tests back to controlName

* add tear down that deletes app

* remove setup logic

* add timeouts

* change timeout to 1

* add back other build commands

* remove scheme

* whitespace change

* update tearDown to use isFirstLaunch

* fix linting issue

* remove isFirstLaunch from UserDefaults and add #if DEBUG

* try moving navigation back to setUpWithError

* whitespace change

* Skip failing date picker tests (#1495)

* Fix BadgeField space bug (#1497)

* attempt to fix space bug

* add comment

* [XCUITests] Activity Indicator tests (#1493)

* initial activity indicator tests

* add transition to dark mode

* whitespace change

* add dark mode color assert

* add default color to identifier

* update comment

* add dark mode + update to use .*

* add #if DEBUG

* add #if DEBUG to SceneDelegate

* add constants

* add type

* change to hex code

* removing color tests

* Revert "removing color tests"

This reverts commit 79c20c0.

* removing color tests again

* remove SceneDelegate change

* small change

* make code more readable + have SwiftUI inherit from UIKit

* remove super

* [XCUITests] Indeterminate Progress Bar tests (#1503)

* add indeterminate progress bar tests

* update SwiftUI to inherit from UIKit

* remove super

* resolve comments

* Resolving demo conflicts

* Resolving TableViewCell merge conflicts

* Taking tokenized tooltip from main - no fluent2

* Getting TVC building again

* Updating tooltip tokens

* Fixing TVC sample data and demo project

* Fixing token values

Co-authored-by: huwilkes <67026548+huwilkes@users.noreply.github.com>
Co-authored-by: Harrie Shin <hyshin@microsoft.com>
Co-authored-by: Sophia Lee <sophia.lee0416@gmail.com>
Co-authored-by: Jeanie Huynh <31874971+jeaniehuynh@users.noreply.github.com>
Co-authored-by: Joanna Qu <55368679+joannaquu@users.noreply.github.com>
Co-authored-by: Lamine Male <106181067+laminesm@users.noreply.github.com>
@joannaquu joannaquu mentioned this pull request Jan 25, 2023
Merged
11 tasks
joannaquu added a commit that referenced this pull request Jan 25, 2023
@joannaquu @laminesm @sophialee0416
[fluent2-tokens] Merging main -> fluent2-tokens (#1515)
c9cd9b2 
* Skip failing date picker tests (#1495)

* Fix BadgeField space bug (#1497)

* attempt to fix space bug

* add comment

* [XCUITests] Activity Indicator tests (#1493)

* initial activity indicator tests

* add transition to dark mode

* whitespace change

* add dark mode color assert

* add default color to identifier

* update comment

* add dark mode + update to use .*

* add #if DEBUG

* add #if DEBUG to SceneDelegate

* add constants

* add type

* change to hex code

* removing color tests

* Revert "removing color tests"

This reverts commit 79c20c0.

* removing color tests again

* remove SceneDelegate change

* small change

* make code more readable + have SwiftUI inherit from UIKit

* remove super

* [XCUITests] Indeterminate Progress Bar tests (#1503)

* add indeterminate progress bar tests

* update SwiftUI to inherit from UIKit

* remove super

* resolve comments

* [XCUITests] Table View Cell tests (#1508)

* add table view cell tests

* move single line asserts to function

* add comment

* Revert "[XCUITests] Table View Cell tests (#1508)" (#1511)

This reverts commit 1339ed0.

* Bumping FluentUI version (0.11.0) #1512

Co-authored-by: Lamine Male <106181067+laminesm@users.noreply.github.com>
Co-authored-by: Sophia Lee <sophia.lee0416@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyzhan7 lyzhan7 lyzhan7 left review comments

@huwilkes huwilkes huwilkes approved these changes

@sophialee0416 sophialee0416 sophialee0416 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joannaquu @sophialee0416 @huwilkes @lyzhan7