Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate screener stories to CSF instead of storiesOf #21779

Closed
ecraig12345 opened this issue Feb 16, 2022 · 4 comments
Closed

Migrate screener stories to CSF instead of storiesOf #21779

ecraig12345 opened this issue Feb 16, 2022 · 4 comments
Labels
Area: Testing Priority 3: Low Resolution: Soft Close Soft closing inactive issues over a certain period

Comments

@ecraig12345
Copy link
Member

Right now in the vr-tests packages we use the deprecated storiesOf format for declaring stories. This will be removed in storybook v7, so we'll eventually need to migrate the vr-tests stories to CSF (component story format).

Storybook has a migration for storiesOf to CSF: npx sb migrate storiesof-to-csf --glob "**/*.stories.js"
https://storybook.js.org/blog/component-story-format/

This doesn't quite work out of box on our stories, but if we make the following manual modifications it will get us a lot of the way there:

  • Find/replace addStory => add (so the mod will recognize it; leaving the extra parameters for now is fine)
  • For anything with multiple storiesOf calls in the same file (at least with the same name), split it into multiple files

The migration more or less works after that (based on a small test). We'll still have to figure out how to restore the functionality of auto-added stories for RTL and different themes (that's what the addStory API did) but there should be some way to do it.

@ecraig12345 ecraig12345 self-assigned this Feb 16, 2022
@ecraig12345 ecraig12345 changed the title Migrate vr-tests stories to CSF instead of storiesOf Migrate screener stories to CSF instead of storiesOf Mar 3, 2022
@ling1726
Copy link
Member

ling1726 commented Mar 3, 2022

Official docs from screener: https://docs.saucelabs.com/visual/faq/#how-do-i-add-screener-steps-to-storybook-component-story-format-csf-stories

@ecraig12345 ecraig12345 removed their assignment Mar 3, 2022
@Hotell
Copy link
Contributor

Hotell commented Mar 4, 2022

moving to backlog, plan is to address this in upcoming 6 months

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Aug 1, 2022
@ecraig12345 ecraig12345 reopened this Aug 1, 2022
@ecraig12345 ecraig12345 removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Aug 1, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Dec 29, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Testing Priority 3: Low Resolution: Soft Close Soft closing inactive issues over a certain period
Projects
None yet
Development

No branches or pull requests

4 participants