Exports MenuItemRole From MenuItem #27941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct wrappers can utilize the roles.
halerankin
assigned procload, miroslavstastny, brianchristopherbrady, chrisdholt and eljefe223 and unassigned layershifter
📊 Bundle size report🤖 This report was generated against 616e79e4ffb38ea60d979e0e43c6695424b341a5 |
chrisdholt
approved these changes
May 22, 2023
There was a problem hiding this comment.
@miroslavstastny may have a slight nuanced improvement for the change file as well
change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json
Outdated
Show resolved
Hide resolved
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 616e79e4ffb38ea60d979e0e43c6695424b341a5 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2de5e4b:
|
…6e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com>
miroslavstastny
approved these changes
May 23, 2023
chrisdholt
added a commit
that referenced
this pull request
Apr 29, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* Exports MenuItemRole so that the Fluent web component Angular and React wrappers can utilize the roles. * Runs yarn change * Update change/@fluentui-web-components-fe7f57a9-65bb-4816-9f01-0aded96e8ce9.json Co-authored-by: Chris Holt <chhol@microsoft.com> --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports from FAST and exports MenuItemRole from the MenuItem component so that the Fluent web component Angular and React wrappers can utilize
role. The component README shows three inputs:role,disabledandchecked. When creating wrappers in Angular and React, theroleattribute cannot be reached.Without this export, I would have to import from FAST in both my React and Angular wrappers:
import { roleForMenuItem } from '@microsoft/fast-foundation';It would be less convoluted to simply leverage the existing property directly from the Fluent web component.