Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(teams-prg): migrate to new slot API #28751

Merged
merged 3 commits into from
Aug 7, 2023
Merged

chore(teams-prg): migrate to new slot API #28751

merged 3 commits into from
Aug 7, 2023

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Aug 7, 2023 •
edited
Loading

New Behavior

Migrates all teams-prg v9 packages to new slot API

@github-actions github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 7, 2023
@bsunderhus bsunderhus mentioned this pull request Aug 4, 2023
Closed
@bsunderhus bsunderhus self-assigned this Aug 7, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 7, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 653 666 5000
Button mount 300 294 5000
Field mount 1127 1182 5000
FluentProvider mount 649 694 5000
FluentProviderWithTheme mount 78 80 10
FluentProviderWithTheme virtual-rerender 65 62 10
FluentProviderWithTheme virtual-rerender-with-unmount 83 68 10
InfoButton mount 10 14 5000
MakeStyles mount 851 858 50000
Persona mount 1821 1803 5000
SpinButton mount 1390 1418 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 7, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9648722:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 7, 2023 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-alert
Alert		 85.295 kB
22.133 kB		 85.328 kB
22.17 kB		 33 B
37 B
react-components
react-components: Button, FluentProvider & webLightTheme		 69 kB
18.626 kB		 68.985 kB
18.63 kB		 -15 B
4 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 208.449 kB
58.124 kB		 208.505 kB
58.131 kB		 56 B
7 B
react-components
react-components: FluentProvider & webLightTheme		 37.737 kB
12.383 kB		 37.573 kB
12.31 kB		 -164 B
-73 B
react-dialog
Dialog (including children components)		 87.667 kB
26.515 kB		 87.131 kB
26.363 kB		 -536 B
-152 B
react-infobutton
InfoButton		 127.112 kB
39.458 kB		 127.105 kB
39.47 kB		 -7 B
12 B
react-infobutton
InfoLabel		 130.697 kB
40.576 kB		 130.692 kB
40.592 kB		 -5 B
16 B
react-menu
Menu (including children components)		 136.49 kB
41.618 kB		 136.04 kB
41.462 kB		 -450 B
-156 B
react-menu
Menu (including selectable components)		 139.254 kB
42.117 kB		 138.726 kB
41.963 kB		 -528 B
-154 B
react-popover
Popover		 115.537 kB
35.988 kB		 115.399 kB
35.938 kB		 -138 B
-50 B
react-provider
FluentProvider		 18.305 kB
6.824 kB		 18.141 kB
6.75 kB		 -164 B
-74 B
react-table
DataGrid		 158.799 kB
42.555 kB		 158.747 kB
42.624 kB		 -52 B
69 B
react-table
Table (Primitives only)		 44.252 kB
12.38 kB		 43.838 kB
12.235 kB		 -414 B
-145 B
react-table
Table as DataGrid		 132.544 kB
34.012 kB		 132.575 kB
34.098 kB		 31 B
86 B
react-table
Table (Selection only)		 77.944 kB
19.306 kB		 77.962 kB
19.391 kB		 18 B
85 B
react-table
Table (Sort only)		 76.563 kB
18.908 kB		 76.581 kB
18.994 kB		 18 B
86 B
react-tags-preview
InteractionTag		 34.728 kB
9.357 kB		 34.304 kB
9.196 kB		 -424 B
-161 B
react-tags-preview
Tag		 26.272 kB
8.598 kB		 25.83 kB
8.421 kB		 -442 B
-177 B
react-tags-preview
TagGroup		 69.574 kB
20.432 kB		 69.426 kB
20.423 kB		 -148 B
-9 B
react-toast
Toast (including Toaster)		 88.669 kB
26.222 kB		 88.11 kB
26.02 kB		 -559 B
-202 B
react-tree
FlatTree		 132.373 kB
37.551 kB		 132.463 kB
37.564 kB		 90 B
13 B
react-tree
PersonaFlatTree		 133.697 kB
37.814 kB		 133.814 kB
37.822 kB		 117 B
8 B
react-tree
PersonaTree		 130.61 kB
36.707 kB		 130.749 kB
36.732 kB		 139 B
25 B
react-tree
Tree		 129.284 kB
36.452 kB		 129.399 kB
36.48 kB		 115 B
28 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 88.89 kB
26.962 kB
react-avatar
Avatar		 48.042 kB
14.632 kB
react-avatar
AvatarGroup		 15.869 kB
6.384 kB
react-avatar
AvatarGroupItem		 64.218 kB
19.116 kB
react-button
Button		 39.503 kB
9.864 kB
react-button
CompoundButton		 46.97 kB
11.37 kB
react-button
MenuButton		 43.861 kB
11.123 kB
react-button
SplitButton		 52.061 kB
12.685 kB
react-button
ToggleButton		 57.931 kB
11.766 kB
react-card
Card - All		 89.985 kB
25.485 kB
react-card
Card		 84.403 kB
23.89 kB
react-card
CardFooter		 9.543 kB
4.011 kB
react-card
CardHeader		 11.962 kB
4.849 kB
react-card
CardPreview		 10.358 kB
4.363 kB
react-datepicker-compat
DatePicker Compat		 218.493 kB
58.297 kB
react-persona
Persona		 55.596 kB
16.642 kB
react-portal-compat
PortalCompatProvider		 6.48 kB
2.203 kB
🤖 This report was generated against b921cbb92c4e023b06577c2e10f5f7e44f25c64d

@size-auditor
Copy link

size-auditor bot commented Aug 7, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b921cbb92c4e023b06577c2e10f5f7e44f25c64d (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 7, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus marked this pull request as ready for review August 7, 2023 08:11
@bsunderhus bsunderhus requested review from a team, chpalac and ling1726 as code owners August 7, 2023 08:11
bsunderhus and others added 2 commits August 7, 2023 11:15
@bsunderhus @layershifter
Update packages/react-components/react-menu/src/components/MenuPopove…
2dfe8aa 
…r/useMenuPopover.ts

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@bsunderhus @layershifter
Update packages/react-components/react-toast/src/components/Toaster/u…
9648722 
…seToaster.tsx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@bsunderhus bsunderhus merged commit e615f12 into microsoft:master Aug 7, 2023
21 checks passed
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 7, 2023
@marcosmoura
Merge branch 'master' into feat/use-motion-presence-hook
91cdd11 
* master:
  chore(cxe-prg): migrate to new slot API (microsoft#28752)
  chore(teams-prg): migrate to new slot API (microsoft#28751)
  chore: re-export slot and assertSlots methods (microsoft#28755)
  Docs(react-tree): Improve docs and stories (microsoft#28741)
  feat: implements nested tree selection (microsoft#28668)
  applying package updates
  applying package updates
  feature(react-utilities): implements new slot methods (`slot` and `assertSlots`) (microsoft#28373)
  fix(TimePicker): Selection now works in locales that don't use "am"/"pm" in their time format (microsoft#28469)
  bugfix: ensures controlled state works properly + (microsoft#28665)
  feat(tokens): Add status color tokens (microsoft#28006)
  feat(tokens): Add colorBrandStroke2Contrast and colorNeutralStrokeAlpha2 (microsoft#28638)
  Made BreadcrumbButton consistent with Item and Link (microsoft#28672)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 7, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-motion
f1270bb 
* master:
  chore(cxe-prg): migrate to new slot API (microsoft#28752)
  chore(teams-prg): migrate to new slot API (microsoft#28751)
  chore: re-export slot and assertSlots methods (microsoft#28755)
  Docs(react-tree): Improve docs and stories (microsoft#28741)
  feat: implements nested tree selection (microsoft#28668)
  applying package updates
  applying package updates
  feature(react-utilities): implements new slot methods (`slot` and `assertSlots`) (microsoft#28373)
  fix(TimePicker): Selection now works in locales that don't use "am"/"pm" in their time format (microsoft#28469)
  bugfix: ensures controlled state works properly + (microsoft#28665)
  feat(tokens): Add status color tokens (microsoft#28006)
  feat(tokens): Add colorBrandStroke2Contrast and colorNeutralStrokeAlpha2 (microsoft#28638)
  Made BreadcrumbButton consistent with Item and Link (microsoft#28672)
  fix(EventListener): do not use `defaultProps` (microsoft#28725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@chpalac chpalac Awaiting requested review from chpalac chpalac is a code owner

@ling1726 ling1726 Awaiting requested review from ling1726 ling1726 is a code owner

Assignees

@bsunderhus bsunderhus

Labels
None yet
Projects
None yet
Milestone
August Project Cycle Q4 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@bsunderhus @fabricteam @layershifter