fix(EventListener): do not use defaultProps
#28725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ling1726
approved these changes
Aug 3, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0f055f1:
|
📊 Bundle size report🤖 This report was generated against 44b128284cf90386b75dfba7336e4950428820bf |
🕵 FluentUIV0 No visual regressions between this PR and main |
Asset size changes
Baseline commit: 44b128284cf90386b75dfba7336e4950428820bf (build) |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 88 | 78 | 1.13:1 |
| ButtonMinimalPerf.default | 88 | 80 | 1.1:1 |
| FormMinimalPerf.default | 243 | 220 | 1.1:1 |
| FlexMinimalPerf.default | 160 | 147 | 1.09:1 |
| AvatarMinimalPerf.default | 107 | 101 | 1.06:1 |
| BoxMinimalPerf.default | 198 | 186 | 1.06:1 |
| ButtonOverridesMissPerf.default | 675 | 639 | 1.06:1 |
| ProviderMinimalPerf.default | 199 | 189 | 1.05:1 |
| ButtonSlotsPerf.default | 315 | 303 | 1.04:1 |
| HeaderMinimalPerf.default | 211 | 202 | 1.04:1 |
| ImageMinimalPerf.default | 224 | 216 | 1.04:1 |
| RefMinimalPerf.default | 110 | 106 | 1.04:1 |
| AlertMinimalPerf.default | 161 | 157 | 1.03:1 |
| AttachmentSlotsPerf.default | 649 | 629 | 1.03:1 |
| CarouselMinimalPerf.default | 256 | 248 | 1.03:1 |
| ListNestedPerf.default | 338 | 328 | 1.03:1 |
| ProviderMergeThemesPerf.default | 674 | 657 | 1.03:1 |
| StatusMinimalPerf.default | 399 | 389 | 1.03:1 |
| TreeMinimalPerf.default | 483 | 471 | 1.03:1 |
| DividerMinimalPerf.default | 205 | 201 | 1.02:1 |
| GridMinimalPerf.default | 198 | 195 | 1.02:1 |
| RadioGroupMinimalPerf.default | 261 | 257 | 1.02:1 |
| ReactionMinimalPerf.default | 216 | 212 | 1.02:1 |
| VideoMinimalPerf.default | 436 | 427 | 1.02:1 |
| AccordionMinimalPerf.default | 78 | 77 | 1.01:1 |
| DropdownManyItemsPerf.default | 395 | 392 | 1.01:1 |
| MenuButtonMinimalPerf.default | 944 | 938 | 1.01:1 |
| SliderMinimalPerf.default | 742 | 738 | 1.01:1 |
| SplitButtonMinimalPerf.default | 2229 | 2199 | 1.01:1 |
| TextAreaMinimalPerf.default | 290 | 286 | 1.01:1 |
| ToolbarMinimalPerf.default | 525 | 521 | 1.01:1 |
| TreeWith60ListItems.default | 87 | 86 | 1.01:1 |
| AnimationMinimalPerf.default | 305 | 304 | 1:1 |
| CheckboxMinimalPerf.default | 1134 | 1137 | 1:1 |
| DialogMinimalPerf.default | 446 | 448 | 1:1 |
| EmbedMinimalPerf.default | 1855 | 1860 | 1:1 |
| LoaderMinimalPerf.default | 196 | 196 | 1:1 |
| PortalMinimalPerf.default | 85 | 85 | 1:1 |
| CustomToolbarPrototype.default | 1478 | 1477 | 1:1 |
| TooltipMinimalPerf.default | 1252 | 1248 | 1:1 |
| ChatMinimalPerf.default | 423 | 428 | 0.99:1 |
| ChatWithPopoverPerf.default | 194 | 196 | 0.99:1 |
| DatepickerMinimalPerf.default | 3513 | 3540 | 0.99:1 |
| DropdownMinimalPerf.default | 1386 | 1404 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 708 | 715 | 0.99:1 |
| LabelMinimalPerf.default | 215 | 217 | 0.99:1 |
| LayoutMinimalPerf.default | 202 | 204 | 0.99:1 |
| PopupMinimalPerf.default | 342 | 344 | 0.99:1 |
| TableManyItemsPerf.default | 1132 | 1138 | 0.99:1 |
| HeaderSlotsPerf.default | 454 | 465 | 0.98:1 |
| InputMinimalPerf.default | 518 | 530 | 0.98:1 |
| ListCommonPerf.default | 384 | 392 | 0.98:1 |
| RosterPerf.default | 1510 | 1539 | 0.98:1 |
| SegmentMinimalPerf.default | 193 | 197 | 0.98:1 |
| TextMinimalPerf.default | 185 | 188 | 0.98:1 |
| ListMinimalPerf.default | 302 | 312 | 0.97:1 |
| CardMinimalPerf.default | 299 | 313 | 0.96:1 |
| IconMinimalPerf.default | 380 | 394 | 0.96:1 |
| ChatDuplicateMessagesPerf.default | 153 | 161 | 0.95:1 |
| MenuMinimalPerf.default | 471 | 495 | 0.95:1 |
| TableMinimalPerf.default | 228 | 241 | 0.95:1 |
| ListWith60ListItems.default | 361 | 384 | 0.94:1 |
| SkeletonMinimalPerf.default | 193 | 206 | 0.94:1 |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 7, 2023
* master: chore(cxe-prg): migrate to new slot API (microsoft#28752) chore(teams-prg): migrate to new slot API (microsoft#28751) chore: re-export slot and assertSlots methods (microsoft#28755) Docs(react-tree): Improve docs and stories (microsoft#28741) feat: implements nested tree selection (microsoft#28668) applying package updates applying package updates feature(react-utilities): implements new slot methods (`slot` and `assertSlots`) (microsoft#28373) fix(TimePicker): Selection now works in locales that don't use "am"/"pm" in their time format (microsoft#28469) bugfix: ensures controlled state works properly + (microsoft#28665) feat(tokens): Add status color tokens (microsoft#28006) feat(tokens): Add colorBrandStroke2Contrast and colorNeutralStrokeAlpha2 (microsoft#28638) Made BreadcrumbButton consistent with Item and Link (microsoft#28672) fix(EventListener): do not use `defaultProps` (microsoft#28725)
|
Is this change in any available release? I am using 0.66.5 and // node_modules/@fluentui/react-component-event-listener/dist/es/EventListener.js
import { useEventListener } from './useEventListener';
export var EventListener = /*#__PURE__*/function () {
function EventListener(props) {
useEventListener(props);
return null;
}
EventListener.defaultProps = {
capture: false
};
return EventListener;
}();
//# sourceMappingURL=EventListener.js.map |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
No deprecation warnings with React 18 in
EventListenercomponent.Related Issue(s)