Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add VivaEngageIcon to @fluentui/react-icons-mdl2 package #28804

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

tomi-msft
Copy link
Contributor

This PR is to add the VivaEngageIcon to the react-icons-mdl2 package

@tomi-msft tomi-msft requested review from a team as code owners August 10, 2023 02:50
@github-actions github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 10, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 10, 2023

📊 Bundle size report

🤖 This report was generated against 50f6cccafe4cf28046507d582cdcb5c3eec3bca8

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 93b9b1a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 10, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Aug 10, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 50f6cccafe4cf28046507d582cdcb5c3eec3bca8 (build)

@khmakoto khmakoto changed the title Add viva icon feat: Add VivaEngageIcon to @fluentui/react-icons-mdl2 package Aug 11, 2023
tomi-msft and others added 2 commits August 15, 2023 14:40
…abe442fe.json

Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
@tomi-msft tomi-msft merged commit c737a3f into microsoft:master Aug 15, 2023
20 checks passed
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 17, 2023
* master: (66 commits)
  fix(react-infobutton): Cursor should be pointer when hovering the button to show it's a button (microsoft#28893)
  chore(react-tags-preview): add docs  (microsoft#28899)
  applying package updates
  fix(react-tree): stablilize `handleActionsRef` created by TreeItem (microsoft#28896)
  bugfix: headless flat tree itemType manual definition (microsoft#28898)
  doc(react-tree): adds a11y edge cases to the docs (microsoft#28897)
  Update DatePickerDescription.md with note about compat components (microsoft#28882)
  chore(react-tree): removes preview warning from the docs (microsoft#28886)
  applying package updates
  fix(public-docsite): Remove image clipping and move top banner under top nav to avoid header issues (microsoft#28885)
  feat(react-tree): stable release (microsoft#28845)
  Virtualizer: Merge scrollref prop with container ref (microsoft#28829)
  chore(react-jsx-runtime): release stable version (microsoft#28880)
  applying package updates
  fix(react-tags-preview): style update - tag hover style should only be on dismiss icon (microsoft#28791)
  applying package updates
  feat(public-docsite): Add topbanner component and use it in the public docsite (microsoft#28870)
  feat: Add VivaEngageIcon to @fluentui/react-icons-mdl2 package (microsoft#28804)
  docs: Remove InfoButton stories in favor of having only InfoLabel stories. (microsoft#28856)
  Added more CY and VR tests to the Breadcrumb  (microsoft#28790)
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 17, 2023
* master: (66 commits)
  fix(react-infobutton): Cursor should be pointer when hovering the button to show it's a button (microsoft#28893)
  chore(react-tags-preview): add docs  (microsoft#28899)
  applying package updates
  fix(react-tree): stablilize `handleActionsRef` created by TreeItem (microsoft#28896)
  bugfix: headless flat tree itemType manual definition (microsoft#28898)
  doc(react-tree): adds a11y edge cases to the docs (microsoft#28897)
  Update DatePickerDescription.md with note about compat components (microsoft#28882)
  chore(react-tree): removes preview warning from the docs (microsoft#28886)
  applying package updates
  fix(public-docsite): Remove image clipping and move top banner under top nav to avoid header issues (microsoft#28885)
  feat(react-tree): stable release (microsoft#28845)
  Virtualizer: Merge scrollref prop with container ref (microsoft#28829)
  chore(react-jsx-runtime): release stable version (microsoft#28880)
  applying package updates
  fix(react-tags-preview): style update - tag hover style should only be on dismiss icon (microsoft#28791)
  applying package updates
  feat(public-docsite): Add topbanner component and use it in the public docsite (microsoft#28870)
  feat: Add VivaEngageIcon to @fluentui/react-icons-mdl2 package (microsoft#28804)
  docs: Remove InfoButton stories in favor of having only InfoLabel stories. (microsoft#28856)
  Added more CY and VR tests to the Breadcrumb  (microsoft#28790)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants