chore(react-tree): stable release #28845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
force-pushed
the
react-tree/chore--stable-release
branch
from
fca994a
to
dfa0c14
Compare
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 622 | 612 | 5000 | |
| Button | mount | 308 | 317 | 5000 | |
| Field | mount | 1095 | 1138 | 5000 | |
| FluentProvider | mount | 696 | 704 | 5000 | |
| FluentProviderWithTheme | mount | 78 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 77 | 72 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 72 | 10 | |
| InfoButton | mount | 10 | 13 | 5000 | |
| MakeStyles | mount | 871 | 870 | 50000 | |
| Persona | mount | 1711 | 1700 | 5000 | |
| SpinButton | mount | 1373 | 1326 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 98 | 79 | 1.24:1 |
| ButtonSlotsPerf.default | 333 | 303 | 1.1:1 |
| RadioGroupMinimalPerf.default | 274 | 252 | 1.09:1 |
| TextMinimalPerf.default | 196 | 181 | 1.08:1 |
| FormMinimalPerf.default | 230 | 215 | 1.07:1 |
| AlertMinimalPerf.default | 160 | 151 | 1.06:1 |
| GridMinimalPerf.default | 199 | 187 | 1.06:1 |
| LoaderMinimalPerf.default | 189 | 180 | 1.05:1 |
| SegmentMinimalPerf.default | 208 | 199 | 1.05:1 |
| TableMinimalPerf.default | 238 | 226 | 1.05:1 |
| AttachmentMinimalPerf.default | 87 | 84 | 1.04:1 |
| AttachmentSlotsPerf.default | 660 | 633 | 1.04:1 |
| ListMinimalPerf.default | 309 | 298 | 1.04:1 |
| ListNestedPerf.default | 328 | 316 | 1.04:1 |
| ToolbarMinimalPerf.default | 537 | 517 | 1.04:1 |
| MenuMinimalPerf.default | 492 | 479 | 1.03:1 |
| ReactionMinimalPerf.default | 214 | 207 | 1.03:1 |
| StatusMinimalPerf.default | 405 | 395 | 1.03:1 |
| CustomToolbarPrototype.default | 1476 | 1434 | 1.03:1 |
| CheckboxMinimalPerf.default | 1127 | 1100 | 1.02:1 |
| RosterPerf.default | 1586 | 1557 | 1.02:1 |
| ProviderMinimalPerf.default | 203 | 199 | 1.02:1 |
| RefMinimalPerf.default | 109 | 107 | 1.02:1 |
| SliderMinimalPerf.default | 738 | 720 | 1.02:1 |
| IconMinimalPerf.default | 385 | 378 | 1.02:1 |
| ButtonOverridesMissPerf.default | 648 | 643 | 1.01:1 |
| CarouselMinimalPerf.default | 265 | 262 | 1.01:1 |
| EmbedMinimalPerf.default | 1855 | 1833 | 1.01:1 |
| InputMinimalPerf.default | 537 | 530 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 713 | 703 | 1.01:1 |
| MenuButtonMinimalPerf.default | 962 | 951 | 1.01:1 |
| PopupMinimalPerf.default | 349 | 347 | 1.01:1 |
| ProviderMergeThemesPerf.default | 670 | 662 | 1.01:1 |
| SplitButtonMinimalPerf.default | 2272 | 2244 | 1.01:1 |
| TreeWith60ListItems.default | 79 | 78 | 1.01:1 |
| ChatMinimalPerf.default | 421 | 423 | 1:1 |
| DialogMinimalPerf.default | 438 | 438 | 1:1 |
| HeaderMinimalPerf.default | 212 | 212 | 1:1 |
| ListCommonPerf.default | 385 | 385 | 1:1 |
| PortalMinimalPerf.default | 85 | 85 | 1:1 |
| TableManyItemsPerf.default | 1115 | 1110 | 1:1 |
| TooltipMinimalPerf.default | 1267 | 1264 | 1:1 |
| VideoMinimalPerf.default | 418 | 419 | 1:1 |
| AvatarMinimalPerf.default | 106 | 107 | 0.99:1 |
| CardMinimalPerf.default | 302 | 306 | 0.99:1 |
| DatepickerMinimalPerf.default | 3652 | 3675 | 0.99:1 |
| DropdownMinimalPerf.default | 1395 | 1414 | 0.99:1 |
| TreeMinimalPerf.default | 479 | 484 | 0.99:1 |
| BoxMinimalPerf.default | 189 | 192 | 0.98:1 |
| ChatWithPopoverPerf.default | 192 | 196 | 0.98:1 |
| DropdownManyItemsPerf.default | 374 | 381 | 0.98:1 |
| LabelMinimalPerf.default | 219 | 223 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 149 | 154 | 0.97:1 |
| FlexMinimalPerf.default | 155 | 159 | 0.97:1 |
| TextAreaMinimalPerf.default | 278 | 286 | 0.97:1 |
| AnimationMinimalPerf.default | 286 | 299 | 0.96:1 |
| HeaderSlotsPerf.default | 455 | 475 | 0.96:1 |
| LayoutMinimalPerf.default | 194 | 202 | 0.96:1 |
| ListWith60ListItems.default | 357 | 370 | 0.96:1 |
| AccordionMinimalPerf.default | 77 | 81 | 0.95:1 |
| DividerMinimalPerf.default | 195 | 205 | 0.95:1 |
| ImageMinimalPerf.default | 215 | 228 | 0.94:1 |
| SkeletonMinimalPerf.default | 186 | 198 | 0.94:1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 573e8c7:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 647 | 648 | 5000 | |
| Breadcrumb | mount | 1663 | 1662 | 1000 | |
| Checkbox | mount | 1716 | 1680 | 5000 | |
| CheckboxBase | mount | 1487 | 1492 | 5000 | |
| ChoiceGroup | mount | 3017 | 2956 | 5000 | |
| ComboBox | mount | 661 | 654 | 1000 | |
| CommandBar | mount | 6205 | 6232 | 1000 | |
| ContextualMenu | mount | 12331 | 12003 | 1000 | |
| DefaultButton | mount | 764 | 753 | 5000 | |
| DetailsRow | mount | 2164 | 2178 | 5000 | |
| DetailsRowFast | mount | 2152 | 2144 | 5000 | |
| DetailsRowNoStyles | mount | 1951 | 2019 | 5000 | |
| Dialog | mount | 2683 | 2621 | 1000 | |
| DocumentCardTitle | mount | 233 | 227 | 1000 | |
| Dropdown | mount | 1982 | 1995 | 5000 | |
| FocusTrapZone | mount | 1107 | 1125 | 5000 | |
| FocusZone | mount | 1056 | 1079 | 5000 | |
| GroupedList | mount | 41417 | 41566 | 2 | |
| GroupedList | virtual-rerender | 19823 | 19754 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50338 | 50688 | 2 | |
| GroupedListV2 | mount | 222 | 226 | 2 | |
| GroupedListV2 | virtual-rerender | 214 | 212 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 222 | 225 | 2 | |
| IconButton | mount | 1094 | 1073 | 5000 | |
| Label | mount | 338 | 324 | 5000 | |
| Layer | mount | 2784 | 2768 | 5000 | |
| Link | mount | 383 | 387 | 5000 | |
| MenuButton | mount | 949 | 942 | 5000 | |
| MessageBar | mount | 21364 | 21377 | 5000 | |
| Nav | mount | 1969 | 1902 | 1000 | |
| OverflowSet | mount | 806 | 771 | 5000 | |
| Panel | mount | 2034 | 1789 | 1000 | |
| Persona | mount | 752 | 757 | 1000 | |
| Pivot | mount | 889 | 873 | 1000 | |
| PrimaryButton | mount | 862 | 838 | 5000 | |
| Rating | mount | 4624 | 4609 | 5000 | |
| SearchBox | mount | 932 | 890 | 5000 | |
| Shimmer | mount | 1848 | 1864 | 5000 | |
| Slider | mount | 1306 | 1331 | 5000 | |
| SpinButton | mount | 2882 | 2877 | 5000 | |
| Spinner | mount | 399 | 392 | 5000 | |
| SplitButton | mount | 1839 | 1821 | 5000 | |
| Stack | mount | 402 | 404 | 5000 | |
| StackWithIntrinsicChildren | mount | 852 | 874 | 5000 | |
| StackWithTextChildren | mount | 2557 | 2598 | 5000 | |
| SwatchColorPicker | mount | 6202 | 6148 | 5000 | |
| TagPicker | mount | 1458 | 1484 | 5000 | |
| Text | mount | 374 | 372 | 5000 | |
| TextField | mount | 971 | 947 | 5000 | |
| ThemeProvider | mount | 827 | 837 | 5000 | |
| ThemeProvider | virtual-rerender | 582 | 584 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1293 | 1293 | 5000 | |
| Toggle | mount | 621 | 607 | 5000 | |
| buttonNative | mount | 202 | 189 | 5000 |
🕵 FluentUIV0 No visual regressions between this PR and main |
🕵 fluentuiv9 No visual regressions between this PR and main |
|
Blocked by #28848 |
bsunderhus
force-pushed
the
react-tree/chore--stable-release
branch
from
dfa0c14
to
d54d303
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: de73662bd4db7d730a3c256d7c900959100f3971 (build) |
bsunderhus
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
JustSlone
approved these changes
Aug 15, 2023
bsunderhus
force-pushed
the
react-tree/chore--stable-release
branch
from
bb455e6
to
bfaa093
Compare
miroslavstastny
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
179 files changed to just release a package as stable is really hard to review. I understand this is caused by a change in the unstable release process in the middle of the component development, hopefully this will not be the case going forward (cc @Hotell, @levithomason)
change/@fluentui-react-components-0688cca2-da81-4fc4-b6a4-5eb65191cf56.json
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-tree/chore--stable-release
branch
from
bfaa093
to
06fdb80
Compare
As the development was ongoing in the middle of the new release process for v9 packages I ended up kind of ignoring it for the sake of the development 🙈, now I'm paying the price with an overly complicated release 😅. I believe for new packages this won't be this dramatic @miroslavstastny |
bsunderhus
force-pushed
the
react-tree/chore--stable-release
branch
2 times, most recently
from
31c3788
to
11fdc28
Compare
🕵 fluentuiv8 No visual regressions between this PR and main |
bsunderhus
force-pushed
the
react-tree/chore--stable-release
branch
3 times, most recently
from
e300272
to
ae05033
Compare
bsunderhus
force-pushed
the
react-tree/chore--stable-release
branch
from
ae05033
to
573e8c7
Compare
tudorpopams
approved these changes
Aug 16, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 17, 2023
* master: (66 commits) fix(react-infobutton): Cursor should be pointer when hovering the button to show it's a button (microsoft#28893) chore(react-tags-preview): add docs (microsoft#28899) applying package updates fix(react-tree): stablilize `handleActionsRef` created by TreeItem (microsoft#28896) bugfix: headless flat tree itemType manual definition (microsoft#28898) doc(react-tree): adds a11y edge cases to the docs (microsoft#28897) Update DatePickerDescription.md with note about compat components (microsoft#28882) chore(react-tree): removes preview warning from the docs (microsoft#28886) applying package updates fix(public-docsite): Remove image clipping and move top banner under top nav to avoid header issues (microsoft#28885) feat(react-tree): stable release (microsoft#28845) Virtualizer: Merge scrollref prop with container ref (microsoft#28829) chore(react-jsx-runtime): release stable version (microsoft#28880) applying package updates fix(react-tags-preview): style update - tag hover style should only be on dismiss icon (microsoft#28791) applying package updates feat(public-docsite): Add topbanner component and use it in the public docsite (microsoft#28870) feat: Add VivaEngageIcon to @fluentui/react-icons-mdl2 package (microsoft#28804) docs: Remove InfoButton stories in favor of having only InfoLabel stories. (microsoft#28856) Added more CY and VR tests to the Breadcrumb (microsoft#28790) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 17, 2023
* master: (66 commits) fix(react-infobutton): Cursor should be pointer when hovering the button to show it's a button (microsoft#28893) chore(react-tags-preview): add docs (microsoft#28899) applying package updates fix(react-tree): stablilize `handleActionsRef` created by TreeItem (microsoft#28896) bugfix: headless flat tree itemType manual definition (microsoft#28898) doc(react-tree): adds a11y edge cases to the docs (microsoft#28897) Update DatePickerDescription.md with note about compat components (microsoft#28882) chore(react-tree): removes preview warning from the docs (microsoft#28886) applying package updates fix(public-docsite): Remove image clipping and move top banner under top nav to avoid header issues (microsoft#28885) feat(react-tree): stable release (microsoft#28845) Virtualizer: Merge scrollref prop with container ref (microsoft#28829) chore(react-jsx-runtime): release stable version (microsoft#28880) applying package updates fix(react-tags-preview): style update - tag hover style should only be on dismiss icon (microsoft#28791) applying package updates feat(public-docsite): Add topbanner component and use it in the public docsite (microsoft#28870) feat: Add VivaEngageIcon to @fluentui/react-icons-mdl2 package (microsoft#28804) docs: Remove InfoButton stories in favor of having only InfoLabel stories. (microsoft#28856) Added more CY and VR tests to the Breadcrumb (microsoft#28790) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
react-tree-previewtoreact-treereact-tree-previeweverywhere toreact-treefor the releasereact-treetoreact-componentsexportsRelated Issue(s)