Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated package - testing pipeline #31220

Closed
wants to merge 4 commits into from
Closed

chore: remove deprecated package - testing pipeline #31220

wants to merge 4 commits into from

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Apr 29, 2024

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Apr 29, 2024
@Hotell Hotell changed the title Remove infobbuton package fix feat(scripts-storybook): make getMetadata throwable via config to be able to process stories glob for packages no longer present in the repo Apr 29, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 29, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Hotell Hotell force-pushed the remove-infobbuton-package-fix branch from b04a28e to ee5a9ec Compare April 29, 2024 12:36
@Hotell
feat(scripts-storybook): make getMetadata throwable via config to be …
d535cf2 
…able to process stories glob for packages no longer present in the repo
@Hotell Hotell force-pushed the remove-infobbuton-package-fix branch from ee5a9ec to d535cf2 Compare April 29, 2024 12:37
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 29, 2024 •
edited

📊 Bundle size report

✅ No changes found

@Hotell Hotell mentioned this pull request Apr 29, 2024
Merged
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 29, 2024 •
edited

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 97 97 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 635 647 5000
Button mount 300 314 5000
Field mount 1138 1105 5000
FluentProvider mount 785 750 5000
FluentProviderWithTheme mount 97 97 10 Possible regression
FluentProviderWithTheme virtual-rerender 51 37 10
FluentProviderWithTheme virtual-rerender-with-unmount 94 91 10
MakeStyles mount 867 864 50000
Persona mount 1789 1734 5000
SpinButton mount 1427 1438 5000
SwatchPicker mount 1534 1572 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 29, 2024 •
edited

Perf Analysis (@fluentui/react-northstar)

⚠️ 3 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AttachmentMinimalPerf.default 85 80 1.06:1 analysis
AccordionMinimalPerf.default 84 80 1.05:1 analysis
GridMinimalPerf.default 186 188 0.99:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 96 82 1.17:1
TextAreaMinimalPerf.default 309 273 1.13:1
RefMinimalPerf.default 112 103 1.09:1
AvatarMinimalPerf.default 113 106 1.07:1
CardMinimalPerf.default 319 299 1.07:1
TableMinimalPerf.default 234 220 1.06:1
ItemLayoutMinimalPerf.default 733 699 1.05:1
SegmentMinimalPerf.default 202 192 1.05:1
SkeletonMinimalPerf.default 198 189 1.05:1
CarouselMinimalPerf.default 263 253 1.04:1
ChatDuplicateMessagesPerf.default 146 141 1.04:1
PortalMinimalPerf.default 86 83 1.04:1
ReactionMinimalPerf.default 210 201 1.04:1
AttachmentSlotsPerf.default 635 616 1.03:1
BoxMinimalPerf.default 194 189 1.03:1
CheckboxMinimalPerf.default 1146 1112 1.03:1
EmbedMinimalPerf.default 1897 1843 1.03:1
FlexMinimalPerf.default 157 152 1.03:1
ListCommonPerf.default 387 377 1.03:1
ListMinimalPerf.default 316 307 1.03:1
ProviderMinimalPerf.default 199 193 1.03:1
RadioGroupMinimalPerf.default 257 249 1.03:1
CustomToolbarPrototype.default 1466 1422 1.03:1
ButtonOverridesMissPerf.default 641 626 1.02:1
DatepickerMinimalPerf.default 3537 3475 1.02:1
DialogMinimalPerf.default 449 441 1.02:1
LayoutMinimalPerf.default 201 197 1.02:1
MenuMinimalPerf.default 513 504 1.02:1
ProviderMergeThemesPerf.default 653 638 1.02:1
TextMinimalPerf.default 194 191 1.02:1
ChatWithPopoverPerf.default 193 192 1.01:1
DropdownMinimalPerf.default 1433 1419 1.01:1
MenuButtonMinimalPerf.default 947 938 1.01:1
PopupMinimalPerf.default 343 338 1.01:1
TreeWith60ListItems.default 80 79 1.01:1
DividerMinimalPerf.default 199 200 1:1
DropdownManyItemsPerf.default 386 386 1:1
ImageMinimalPerf.default 225 226 1:1
ListNestedPerf.default 323 323 1:1
LoaderMinimalPerf.default 189 189 1:1
RosterPerf.default 1582 1583 1:1
SliderMinimalPerf.default 725 726 1:1
SplitButtonMinimalPerf.default 2217 2219 1:1
TableManyItemsPerf.default 1096 1096 1:1
ToolbarMinimalPerf.default 538 538 1:1
VideoMinimalPerf.default 425 426 1:1
AlertMinimalPerf.default 158 160 0.99:1
AnimationMinimalPerf.default 303 305 0.99:1
ButtonSlotsPerf.default 312 316 0.99:1
ChatMinimalPerf.default 426 429 0.99:1
FormMinimalPerf.default 213 215 0.99:1
InputMinimalPerf.default 537 544 0.99:1
IconMinimalPerf.default 382 384 0.99:1
TreeMinimalPerf.default 463 466 0.99:1
HeaderSlotsPerf.default 457 467 0.98:1
LabelMinimalPerf.default 221 225 0.98:1
TooltipMinimalPerf.default 1248 1268 0.98:1
ListWith60ListItems.default 375 387 0.97:1
StatusMinimalPerf.default 393 409 0.96:1
HeaderMinimalPerf.default 197 207 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 29, 2024 •
edited

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 29, 2024 •
edited

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 29, 2024 •
edited

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 29, 2024 •
edited

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 635 634 5000
Breadcrumb mount 1689 1738 1000
Checkbox mount 1721 1720 5000
CheckboxBase mount 1493 1500 5000
ChoiceGroup mount 3022 3063 5000
ComboBox mount 667 686 1000
CommandBar mount 6653 6669 1000
ContextualMenu mount 11672 11686 1000
DefaultButton mount 778 799 5000
DetailsRow mount 2234 2185 5000
DetailsRowFast mount 2165 2213 5000
DetailsRowNoStyles mount 2014 1988 5000
Dialog mount 2648 2645 1000
DocumentCardTitle mount 228 230 1000
Dropdown mount 2001 2000 5000
FocusTrapZone mount 1186 1142 5000
FocusZone mount 1092 1060 5000
GroupedList mount 42332 46364 2
GroupedList virtual-rerender 17936 20142 2
GroupedList virtual-rerender-with-unmount 50580 51001 2
GroupedListV2 mount 224 225 2
GroupedListV2 virtual-rerender 212 208 2
GroupedListV2 virtual-rerender-with-unmount 220 234 2
IconButton mount 1133 1150 5000
Label mount 334 341 5000
Layer mount 2696 2730 5000
Link mount 399 412 5000
MenuButton mount 978 1005 5000
MessageBar mount 21396 21397 5000
Nav mount 2013 2028 1000
OverflowSet mount 783 770 5000
Panel mount 2079 1800 1000
Persona mount 740 747 1000
Pivot mount 894 898 1000
PrimaryButton mount 937 920 5000
Rating mount 4645 4639 5000
SearchBox mount 932 942 5000
Shimmer mount 1882 1857 5000
Slider mount 1314 1312 5000
SpinButton mount 2919 3025 5000
Spinner mount 392 402 5000
SplitButton mount 1890 1834 5000
Stack mount 397 405 5000
StackWithIntrinsicChildren mount 864 870 5000
StackWithTextChildren mount 2618 2653 5000
SwatchColorPicker mount 6427 6333 5000
TagPicker mount 1494 1450 5000
Text mount 365 364 5000
TextField mount 933 924 5000
ThemeProvider mount 860 831 5000
ThemeProvider virtual-rerender 585 593 5000
ThemeProvider virtual-rerender-with-unmount 1275 1277 5000
Toggle mount 611 612 5000
buttonNative mount 183 189 5000

@Hotell
feat(test-ssr): add custom esbuild-plugin to properly resolve TS path…
b9dcc79 
… aliases which stopped working starting esbuild 0.19
@Hotell Hotell changed the title feat(scripts-storybook): make getMetadata throwable via config to be able to process stories glob for packages no longer present in the repo chore: remove deprecated package - testing pipeline Apr 30, 2024
@Hotell Hotell mentioned this pull request Apr 30, 2024
Merged
@Hotell Hotell closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopranopillow sopranopillow Awaiting requested review from sopranopillow sopranopillow will be requested when the pull request is marked ready for review sopranopillow is a code owner

@JustSlone JustSlone Awaiting requested review from JustSlone JustSlone will be requested when the pull request is marked ready for review JustSlone is a code owner

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar will be requested when the pull request is marked ready for review jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams will be requested when the pull request is marked ready for review tudorpopams is a code owner

Assignees
No one assigned
Labels
Status: Do Not Merge 🚫
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hotell @fabricteam @sopranopillow