Skip to content

feat(test-ssr): add custom esbuild-plugin to properly resolve TS path aliases which stopped working starting esbuild 0.19#31227

Merged
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:test-ssr/bring-ts-path-aliases-back
Apr 30, 2024
Merged

feat(test-ssr): add custom esbuild-plugin to properly resolve TS path aliases which stopped working starting esbuild 0.19#31227
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:test-ssr/bring-ts-path-aliases-back

Conversation

@Hotell
Copy link
Copy Markdown
Contributor

@Hotell Hotell commented Apr 30, 2024

Previous Behavior

Esbuild stopped resolving TS path aliases since version 0.19 (BREAKING CHANGE)

https://github.com/evanw/esbuild/blob/main/CHANGELOG.md#0190 /
image

With this in place our SSR test are working by "accident" ( lage scheduling build task prior to executing test-ssr ),
and following pipeline issues might start happening at any time (#29327).

This issue started to appear in one of PR's that removes a deprecated package from the repo #31007

New Behavior

More context

Even if we added build task as pre-requirement for test-ssr pipeline issues would appear sooner than later.

So we can either:

  • provide proper dependency declarations to all packages ( which would introduce circular dependencies - this will be mitigated after implementing [Feature]: improve type-checking performance #30516) + moving test-ssr to *-stories packages
  • implement tsConfigPathAliases esbuild plugin

Ideal solution is to have both so until that type-checking epic is done

Related Issue(s)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants