chore: Remove react-infobutton in favor of keeping only react-infolabel by sopranopillow · Pull Request #31007 · microsoft/fluentui

sopranopillow · 2024-04-09T15:01:50Z

Since react-infobutton has been deprecated and is no longer in use, it is confusing to know which infobutton files are the correct ones for users that don't have insight on its history. Now that we have react-infolabel we should only keep the package that's currently in use.

While we are removing this, react-components will still re-export the package since removing it would break semver even though it's under /unstable.

codesandbox-ci · 2024-04-09T15:15:09Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam · 2024-04-09T15:18:50Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2024-04-09T15:19:09Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender-with-unmount	76	68	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	594	628	5000
Button	mount	294	320	5000
Field	mount	1102	1169	5000
FluentProvider	mount	696	722	5000
FluentProviderWithTheme	mount	81	87	10
FluentProviderWithTheme	virtual-rerender	33	37	10
FluentProviderWithTheme	virtual-rerender-with-unmount	76	68	10	Possible regression
MakeStyles	mount	851	857	50000
Persona	mount	1793	1749	5000
SpinButton	mount	1399	1407	5000
SwatchPicker	mount	1494	1560	5000

fabricteam · 2024-04-09T15:21:27Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
ButtonMinimalPerf.default	90	89	1.01:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AttachmentMinimalPerf.default	97	76	1.28:1
CarouselMinimalPerf.default	272	247	1.1:1
TextMinimalPerf.default	196	178	1.1:1
SegmentMinimalPerf.default	204	187	1.09:1
AvatarMinimalPerf.default	114	106	1.08:1
DividerMinimalPerf.default	207	191	1.08:1
TextAreaMinimalPerf.default	310	286	1.08:1
ButtonSlotsPerf.default	328	306	1.07:1
FormMinimalPerf.default	236	220	1.07:1
ReactionMinimalPerf.default	224	210	1.07:1
DropdownManyItemsPerf.default	403	385	1.05:1
ItemLayoutMinimalPerf.default	726	694	1.05:1
LoaderMinimalPerf.default	192	183	1.05:1
ListMinimalPerf.default	306	293	1.04:1
ProviderMinimalPerf.default	203	195	1.04:1
ChatMinimalPerf.default	437	423	1.03:1
ChatWithPopoverPerf.default	208	202	1.03:1
DropdownMinimalPerf.default	1436	1400	1.03:1
GridMinimalPerf.default	189	183	1.03:1
LabelMinimalPerf.default	217	210	1.03:1
SplitButtonMinimalPerf.default	2290	2226	1.03:1
TableMinimalPerf.default	245	237	1.03:1
CheckboxMinimalPerf.default	1145	1124	1.02:1
MenuButtonMinimalPerf.default	961	942	1.02:1
PopupMinimalPerf.default	344	338	1.02:1
SkeletonMinimalPerf.default	197	193	1.02:1
StatusMinimalPerf.default	401	394	1.02:1
ChatDuplicateMessagesPerf.default	153	151	1.01:1
EmbedMinimalPerf.default	1862	1844	1.01:1
LayoutMinimalPerf.default	204	201	1.01:1
ListCommonPerf.default	378	374	1.01:1
PortalMinimalPerf.default	84	83	1.01:1
ProviderMergeThemesPerf.default	651	646	1.01:1
RefMinimalPerf.default	110	109	1.01:1
SliderMinimalPerf.default	760	754	1.01:1
IconMinimalPerf.default	382	380	1.01:1
TooltipMinimalPerf.default	1281	1267	1.01:1
TreeMinimalPerf.default	493	490	1.01:1
AttachmentSlotsPerf.default	651	653	1:1
ButtonOverridesMissPerf.default	649	650	1:1
DialogMinimalPerf.default	441	442	1:1
HeaderSlotsPerf.default	464	465	1:1
ImageMinimalPerf.default	222	223	1:1
ListNestedPerf.default	326	326	1:1
ListWith60ListItems.default	370	371	1:1
RadioGroupMinimalPerf.default	262	262	1:1
VideoMinimalPerf.default	425	425	1:1
AccordionMinimalPerf.default	85	86	0.99:1
AlertMinimalPerf.default	149	150	0.99:1
DatepickerMinimalPerf.default	3518	3543	0.99:1
FlexMinimalPerf.default	153	155	0.99:1
HeaderMinimalPerf.default	205	207	0.99:1
InputMinimalPerf.default	534	541	0.99:1
MenuMinimalPerf.default	494	502	0.98:1
CustomToolbarPrototype.default	1458	1486	0.98:1
ToolbarMinimalPerf.default	545	554	0.98:1
AnimationMinimalPerf.default	298	307	0.97:1
BoxMinimalPerf.default	188	193	0.97:1
TreeWith60ListItems.default	91	94	0.97:1
TableManyItemsPerf.default	1109	1151	0.96:1
RosterPerf.default	1545	1626	0.95:1
CardMinimalPerf.default	293	318	0.92:1

fabricteam · 2024-04-09T15:24:19Z

📊 Bundle size report

✅ No changes found

fabricteam · 2024-04-09T15:27:09Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	617	622	5000
Breadcrumb	mount	1658	1671	1000
Checkbox	mount	1689	1716	5000
CheckboxBase	mount	1483	1477	5000
ChoiceGroup	mount	2950	2973	5000
ComboBox	mount	694	716	1000
CommandBar	mount	6457	6532	1000
ContextualMenu	mount	11943	12013	1000
DefaultButton	mount	788	782	5000
DetailsRow	mount	2179	2224	5000
DetailsRowFast	mount	2266	2207	5000
DetailsRowNoStyles	mount	2031	2061	5000
Dialog	mount	2681	2678	1000
DocumentCardTitle	mount	233	232	1000
Dropdown	mount	2020	2003	5000
FocusTrapZone	mount	1140	1129	5000
FocusZone	mount	1083	1094	5000
GroupedList	mount	42043	42133	2
GroupedList	virtual-rerender	17920	20106	2
GroupedList	virtual-rerender-with-unmount	50801	51078	2
GroupedListV2	mount	211	232	2
GroupedListV2	virtual-rerender	205	210	2
GroupedListV2	virtual-rerender-with-unmount	228	223	2
IconButton	mount	1114	1118	5000
Label	mount	340	343	5000
Layer	mount	2756	2741	5000
Link	mount	410	398	5000
MenuButton	mount	971	977	5000
MessageBar	mount	21315	21222	5000
Nav	mount	1984	2091	1000
OverflowSet	mount	795	792	5000
Panel	mount	1848	1769	1000
Persona	mount	745	751	1000
Pivot	mount	925	907	1000
PrimaryButton	mount	925	926	5000
Rating	mount	4707	4697	5000
SearchBox	mount	924	926	5000
Shimmer	mount	1858	1880	5000
Slider	mount	1335	1365	5000
SpinButton	mount	2919	3010	5000
Spinner	mount	392	401	5000
SplitButton	mount	1875	1875	5000
Stack	mount	408	404	5000
StackWithIntrinsicChildren	mount	875	835	5000
StackWithTextChildren	mount	2664	2590	5000
SwatchColorPicker	mount	6351	6367	5000
TagPicker	mount	1435	1467	5000
Text	mount	378	383	5000
TextField	mount	937	945	5000
ThemeProvider	mount	836	841	5000
ThemeProvider	virtual-rerender	594	585	5000
ThemeProvider	virtual-rerender-with-unmount	1298	1275	5000
Toggle	mount	612	595	5000
buttonNative	mount	192	190	5000

fabricteam · 2024-04-09T15:28:24Z

🕵 fluentuiv9 No visual regressions between this PR and main

…to remove-infobutton-package

Hotell · 2024-04-12T14:07:08Z

wondering what happened to all these snapshots with tabster ? this should not be part of this PR

yarn.lock

…to remove-infobutton-package

fabricteam · 2024-04-24T00:12:42Z

🕵 FluentUIV0 No visual regressions between this PR and main

sopranopillow · 2024-04-24T18:50:10Z

Looks like this breaks test-ssr. The dependency is found correctly in root node_modules, but then its dependencies like @fluentui/react-jsx-runtime/jsx-runtime point towards a lib folder that is not being generated in node_modules.

any clues @Hotell or @layershifter?

JustSlone

Signing off now on the codeowner change

Hotell · 2024-04-29T12:41:34Z

Looks like this breaks test-ssr. The dependency is found correctly in root node_modules, but then its dependencies like @fluentui/react-jsx-runtime/jsx-runtime point towards a lib folder that is not being generated in node_modules.

any clues @Hotell or @layershifter?

2 issues:

Storybook:

there is a change needed in how we obtain storybook globs from packages from public docsite chore: remove deprecated package - testing pipeline #31220

SSR:

i'm unable run the suite locally , getting lot of timeout errors which will fail eventually

UPDATE: i can pass whole suite locally only if I turn off pupeteer timeout via timeout: 0 ( not sure if this is something we wanna do on CI , wdyt @layershifter ? )

esbuild stopped supporting TS path aliases since version 0.19
https://github.com/evanw/esbuild/blob/main/CHANGELOG.md#0190 /

So our current configuration and setup was a "ticking bomb" like following setup with cypress.

Solution:

Even if we added build task as pre-requirement for test-ssr these issues would appear sooner than later.

So we can either:

provide proper dependency declarations to all packages ( which would introduce circular dependencies - this will be mitigated after implementing [Feature]: improve type-checking performance #30516) + moving test-ssr to *-stories packages
implement tsConfigPathAliases esbuild plugin

Ideal solution is to have probably both so until that type-checking epic is done I created esbuild plugin to add ts path resolution back -> everything works as before
b9dcc79

layershifter · 2024-04-30T09:39:40Z

Ideal solution is to have probably both so until that type-checking epic is done I created esbuild plugin to add ts path resolution back -> everything works as before

@Hotell agree with your proposal 👍 Thx for looking into that ❤️

Hotell · 2024-04-30T10:50:15Z

@sopranopillow Once these 2 PRs land to master , update your branch to get unblocked

feat(scripts-storybook): make getMetadata throwable via config to be able to process stories glob for packages no longer present in the repo #31226
feat(test-ssr): add custom esbuild-plugin to properly resolve TS path aliases which stopped working starting esbuild 0.19 #31227

Hotell · 2024-05-02T13:17:29Z

@sopranopillow Once these 2 PRs land to master , update your branch to get unblocked

feat(scripts-storybook): make getMetadata throwable via config to be able to process stories glob for packages no longer present in the repo #31226

feat(test-ssr): add custom esbuild-plugin to properly resolve TS path aliases which stopped working starting esbuild 0.19 #31227

both landed to master, now your PR is unblocked 🥳 !

…to remove-infobutton-package

…el (microsoft#31007)

chore: Remove react-infobutton in favor of keeping only react-infolabel.

7aa0a40

sopranopillow self-assigned this Apr 9, 2024

sopranopillow added 2 commits April 9, 2024 10:41

Merge branch 'master' of https://www.github.com/microsoft/fluentui in…

166f864

…to remove-infobutton-package

updating snapshots

4682653

Hotell reviewed Apr 12, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

Hotell reviewed Apr 12, 2024

View reviewed changes

yarn.lock Show resolved Hide resolved

sopranopillow added 3 commits April 23, 2024 16:35

reverting snapshots

137413f

Merge branch 'master' of https://www.github.com/microsoft/fluentui in…

80c9fd0

…to remove-infobutton-package

revert change logs

a088f85

sopranopillow marked this pull request as ready for review April 23, 2024 23:54

sopranopillow requested review from a team, JustSlone, jurokapsiar and tudorpopams as code owners April 23, 2024 23:54

JustSlone approved these changes Apr 26, 2024

View reviewed changes

sopranopillow added 2 commits May 2, 2024 09:19

Merge branch 'master' of https://www.github.com/microsoft/fluentui in…

f7cf9d9

…to remove-infobutton-package

u

c4ef895

TristanWatanabe approved these changes May 2, 2024

View reviewed changes

sopranopillow merged commit cca849d into microsoft:master May 3, 2024

sopranopillow deleted the remove-infobutton-package branch May 3, 2024 00:11

Hotell mentioned this pull request Jun 10, 2024

chore: remove react-alert from monorepo #31642

Merged

miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024

chore: Remove react-infobutton in favor of keeping only react-infolab…

b967347

…el (microsoft#31007)

Hotell mentioned this pull request Oct 7, 2025

feat: bring back removed deprecated packages react-alert,react-infobutton,react-virtualizer and add React 19 support #35285

Merged

Conversation

sopranopillow commented Apr 9, 2024

Uh oh!

codesandbox-ci bot commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

Uh oh!

fabricteam commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

Hotell commented Apr 12, 2024

Uh oh!

Uh oh!

Uh oh!

fabricteam commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

sopranopillow commented Apr 24, 2024

Uh oh!

JustSlone left a comment

Choose a reason for hiding this comment

Uh oh!

Hotell commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

layershifter commented Apr 30, 2024

Uh oh!

Hotell commented Apr 30, 2024

Uh oh!

Hotell commented May 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codesandbox-ci bot commented Apr 9, 2024 •

edited

Loading

fabricteam commented Apr 9, 2024 •

edited

Loading

fabricteam commented Apr 9, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Apr 9, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Apr 9, 2024 •

edited

Loading

fabricteam commented Apr 9, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Apr 9, 2024 •

edited

Loading

fabricteam commented Apr 24, 2024 •

edited

Loading

Hotell commented Apr 29, 2024 •

edited

Loading