Support building with GCC v9.x #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `labs()` function operates, as the initial `l` suggests, on `long` parameters. However, in `config.c` we tried to use it on values of type `intmax_t`. This problem was found by GCC v9.x. To fix it, let's just "unroll" the function (i.e. negate the value if it is negative). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This was referenced Jul 23, 2019
jeffhostetler
approved these changes
Jul 23, 2019
derrickstolee
approved these changes
Jul 24, 2019
derrickstolee
approved these changes
Jul 24, 2019
derrickstolee
added a commit
to derrickstolee/VFSForGit
that referenced
this pull request
Jul 24, 2019
Includes changes from: * microsoft/git#158 * microsoft/git#159 * microsoft/git#160 * microsoft/git#162 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
added a commit
to microsoft/VFSForGit
that referenced
this pull request
Jul 24, 2019
Includes changes from: * microsoft/git#158 (experimental tracing: trace threading and cache-tree extension) * microsoft/git#159 (experimental tracing: prime_cache_tree()) * microsoft/git#160 (experimental tracing: checkout and reset perf) * microsoft/git#162 (support building with GCC v9.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to git-for-windows#2258
It is necessary because MSYS2 (and therefore, Git for Windows' SDK) switched to GCC v9.x for the MINGW builds.