Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in error message #1322

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Fix typo in error message #1322

merged 1 commit into from
Mar 10, 2022

Conversation

SeanTAllen
Copy link
Contributor

Signed-off-by: Sean T. Allen seanallen@microsoft.com

@SeanTAllen SeanTAllen requested a review from a team as a code owner March 10, 2022 18:08
@dcantah
Copy link
Contributor

dcantah commented Mar 10, 2022

You'll need to cd to test and run go mod vendor + go mod tidy

dcantah
dcantah approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after the above

@SeanTAllen
Fix typo in error message
f663bc3 
Signed-off-by: Sean T. Allen <seanallen@microsoft.com>
@jterry75
Copy link
Contributor

@dcantah - Is there a spellcheck linter? I make mistakes like this all the time, seems like since its public code anyways when its checked in a public spellchecker should be fine to run on it right?

@SeanTAllen
Copy link
Contributor Author

It has been my experience that spellcheckers on code become a nightmare.

@dcantah
Copy link
Contributor

dcantah commented Mar 10, 2022

Yea, I'm not sure I'd have high hopes for a spellcheck linter but one does exist that's disabled by default for golangci-lint https://golangci-lint.run/usage/linters/#misspell

@jterry75
Copy link
Contributor

Haha. Its no so bad right... Win32, IOCP, IOCTL, containerd, fuse, <- Hey that one would work...

@dcantah
Copy link
Contributor

dcantah commented Mar 10, 2022

I wonder if it would complain about containerd needing to be containers*

@SeanTAllen
Copy link
Contributor Author

@dcantah CI passed.

@dcantah dcantah merged commit 5f4ec16 into microsoft:master Mar 10, 2022
@anmaxvl anmaxvl mentioned this pull request Apr 22, 2022
Merged
anmaxvl added a commit to anmaxvl/hcsshim that referenced this pull request Apr 22, 2022
@anmaxvl
Revert "Fix working_dir negative test error expectation (microsoft#1348…
77b0ccc 
…)"

This reverts commit 2028de8.

During local testing a gcs with an older version of security policy
was used when doing the fix: microsoft#1322. As we can see, the quotations
weren't there. However, later a PR was merged, which added them: microsoft#1311

Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl added a commit that referenced this pull request Apr 22, 2022
@anmaxvl
Revert "Fix working_dir negative test error expectation (#1348)" (#1368)
8e6c081 
This reverts commit 2028de8.

During local testing a gcs with an older version of security policy
was used when doing the fix: #1322. As we can see, the quotations
weren't there. However, later a PR was merged, which added them: #1311

Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
@ambarve
Merged PR 5895108: update ADO to d36cc7c
6a5be6f 
Related work items: #1240, #1241, #1258, #1260, #1270, #1271, #1272, #1279, #1286, #1288, #1289, #1292, #1293, #1294, #1295, #1297, #1298, #1299, #1301, #1305, #1307, #1308, #1309, #1310, #1313, #1314, #1315, #1318, #1320, #1321, #1322, #1324, #1326, #1328, #1332, #1333, #1334, #1335, #1337
anmaxvl added a commit that referenced this pull request Feb 7, 2023
@anmaxvl
Merged PR 5999316: Update ADO to dbb347e
437abac 
Sync ADO with upstream to enable including test GCS binaries as
part of dev-pipeline

Related work items: #1311, #1322, #1341, #1343, #1345, #1347, #1348, #1350, #1353, #1354, #1355, #1358, #1361, #1365, #1368, #1369, #1370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SeanTAllen @dcantah @jterry75