Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix working_dir negative test error expectation (#1348)" #1368

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Revert "Fix working_dir negative test error expectation (#1348)" #1368

merged 1 commit into from
Apr 22, 2022

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Apr 22, 2022

This reverts commit 2028de8.

@anmaxvl anmaxvl requested a review from a team as a code owner April 22, 2022 00:52
@anmaxvl anmaxvl force-pushed the tests/fix-working_dir-policy-test branch from ccf0a6f to ac2931e Compare April 22, 2022 01:07
helsaawy
helsaawy approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@helsaawy helsaawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the context for removing and re-adding the quotes?

@anmaxvl
Copy link
Contributor Author

anmaxvl commented Apr 22, 2022

I think I messed up my local testing and was using gcs with an older version of security policy when doing the fix: #1322. As you can see, the quotations aren't there. However, I later merged a PR, which added them: #1311.

dcantah
dcantah approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to have the reason for the revert in the commit description before you check in

@anmaxvl
Revert "Fix working_dir negative test error expectation (microsoft#1348…
77b0ccc 
…)"

This reverts commit 2028de8.

During local testing a gcs with an older version of security policy
was used when doing the fix: microsoft#1322. As we can see, the quotations
weren't there. However, later a PR was merged, which added them: microsoft#1311

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl force-pushed the tests/fix-working_dir-policy-test branch from ac2931e to 77b0ccc Compare April 22, 2022 17:21
@anmaxvl anmaxvl merged commit 8e6c081 into microsoft:master Apr 22, 2022
@anmaxvl anmaxvl deleted the tests/fix-working_dir-policy-test branch April 22, 2022 17:32
anmaxvl added a commit that referenced this pull request Feb 7, 2023
@anmaxvl
Merged PR 5999316: Update ADO to dbb347e
437abac 
Sync ADO with upstream to enable including test GCS binaries as
part of dev-pipeline

Related work items: #1311, #1322, #1341, #1343, #1345, #1347, #1348, #1350, #1353, #1354, #1355, #1358, #1361, #1365, #1368, #1369, #1370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

@helsaawy helsaawy helsaawy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anmaxvl @dcantah @helsaawy