Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect console size for host process containers #1326

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Respect console size for host process containers #1326

merged 1 commit into from
Mar 15, 2022

Conversation

dcantah
Copy link
Contributor

@dcantah dcantah commented Mar 12, 2022

Previously the values in the spec weren't being used.

This change additionally changes the defaults to an 80 width and 25 height
to match what cexecsvc/hcs sets.

@dcantah
Respect console size for hostprocess containers
1c23cf1 
Previously the values in the spec weren't being used.

This change additionally changes the defaults to an 80 width and 25 height
to match what cexecsvc/hcs sets.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
@dcantah dcantah requested a review from a team as a code owner March 12, 2022 02:49
@anmaxvl anmaxvl self-assigned this Mar 12, 2022
@dcantah dcantah merged commit abf92f5 into microsoft:master Mar 15, 2022
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
@ambarve
Merged PR 5895108: update ADO to d36cc7c
6a5be6f 
Related work items: #1240, #1241, #1258, #1260, #1270, #1271, #1272, #1279, #1286, #1288, #1289, #1292, #1293, #1294, #1295, #1297, #1298, #1299, #1301, #1305, #1307, #1308, #1309, #1310, #1313, #1314, #1315, #1318, #1320, #1321, #1322, #1324, #1326, #1328, #1332, #1333, #1334, #1335, #1337
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@dcantah
Respect console size for hostprocess containers (microsoft#1326)
39d4d0b 
Previously the values in the spec weren't being used.

This change additionally changes the defaults to an 80 width and 25 height
to match what cexecsvc/hcs sets.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helsaawy helsaawy helsaawy approved these changes

@anmaxvl anmaxvl anmaxvl approved these changes

Assignees

@anmaxvl anmaxvl

@katiewasnothere katiewasnothere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcantah @anmaxvl @helsaawy @katiewasnothere