Always set SECURITY_POLICY env var, even for open door policy. #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
force-pushed
the
security-policy-env
branch
from
2eee901
to
90ba716
Compare
helsaawy
approved these changes
May 13, 2022
anmaxvl
force-pushed
the
security-policy-env
branch
from
90ba716
to
95ced2b
Compare
anmaxvl
force-pushed
the
security-policy-env
branch
2 times, most recently
from
45f78c2
to
d79e3d2
Compare
katiewasnothere
approved these changes
Jun 17, 2022
katiewasnothere
approved these changes
Jun 23, 2022
Previously SECURITY_POLICY env var was set for container init process only when StandardSecurityPolicyEnforcer was in use, however the environment variable is useful even with OpenDoor enforcer. Address this gap by updating enforcers and adding an accessor method. Signed-off-by: Maksim An <maksiman@microsoft.com>
Update tests Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
security-policy-env
branch
from
1a97584
to
77eab4d
Compare
|
@anmaxvl can we get this merged? |
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Jul 11, 2022
…soft#1397) Previously SECURITY_POLICY env var was set for container init process only when StandardSecurityPolicyEnforcer was in use, however the environment variable is useful even with OpenDoor enforcer. Address this gap by updating enforcers and adding an accessor method. Add annotation to set SECURITY_POLICY env for containers. Export oci.ParseAnnotationsBool Update tests Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously SECURITY_POLICY env var was set for container init process
only when StandardSecurityPolicyEnforcer was in use, however the
environment variable is useful even with OpenDoor enforcer.
Address this gap by updating enforcers and adding an accessor
method.
The
SECURITY_POLICYenvironment variable will be set only whenthe appropriate annotation says so:
"io.microsoft.virtualmachine.lcow.securitypolicy.env"Signed-off-by: Maksim An maksiman@microsoft.com