downgrade mingw #1440
downgrade mingw #1440
Conversation
|
Oh thanks! @gabriel-samfira Was working on this also |
|
For more context on the reason for the downgrade containerd/containerd#7062 |
I'll undraft the PR once the CI passes. for some reason it's not an issue on Push, but it is on Pull Request 🤷 |
Also, not sure what fix @gabriel-samfira has ben working on, but if it's more comprehensive, then I'll close this PR. |
For more context on the reason for the downgrade containerd/containerd#7062 Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
fix-integration-tests
branch
from
c6b2d67
to
6de3330
Compare
|
Hi @anmaxvl, This fix is exactly what I intended to do. It's no more comprehensive than this. At @dcantah suggestion, I was hoping to disable CGO altogether, but the race detector needs it. I should have done this in the initial PR, but I wasn't sure if this was 100% reproducible. The first batch of tests I ran in my fork did not exhibit this bug. It happened once in the PR, but didn't on a second run. So i wrote it off as a fluke considering the high repro rate in the containerd CI vs that one occurrence. In any case, you beet me to it. Thanks! |
For more context on the reason for the downgrade containerd/containerd#7062 Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An maksiman@microsoft.com