Correctly set silo field when opening job object #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevpar
reviewed
Jun 22, 2022
kevpar
reviewed
Jun 22, 2022
helsaawy
approved these changes
Jun 22, 2022
helsaawy
reviewed
Jun 22, 2022
dcantah
force-pushed
the
jobobj-opensilo
branch
2 times, most recently
from
a6700d3
to
66618c5
Compare
|
Rebased to pickup CI fix for mingw |
|
@kevpar ptal when you get a chance again |
kevpar
reviewed
Jun 29, 2022
We don't set the silo field on Open of an existing job object today. This is useful if once opening a job we want to bind a file that only that silo can see as it relies on atomically checking the `silo` u32 field to determine if we can carry out the operation. The manner in which we check if the job is a silo is by using a new jobobject information class with QueryInformationJobObject that fails unless the job is a silo. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Change to isJobSilo from pointer receiver method as calling a method on an object we made in the same function is a bit odd. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
|
As a side note, it seems weird to have |
Agree, especially as it does nothing for Open |
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Jul 11, 2022
* Correctly set silo field when opening job object We don't set the silo field on Open of an existing job object today. This is useful if once opening a job we want to bind a file that only that silo can see as it relies on atomically checking the `silo` u32 field to determine if we can carry out the operation. The manner in which we check if the job is a silo is by using a new jobobject information class with QueryInformationJobObject that fails unless the job is a silo. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* Correctly set silo field when opening job object We don't set the silo field on Open of an existing job object today. This is useful if once opening a job we want to bind a file that only that silo can see as it relies on atomically checking the `silo` u32 field to determine if we can carry out the operation. The manner in which we check if the job is a silo is by using a new jobobject information class with QueryInformationJobObject that fails unless the job is a silo. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't set the silo field on Open of an existing job object today.
This is useful if once opening a job we want to bind a file that only
that silo can see as it relies on atomically checking the
silou32field to determine if we can carry out the operation.
The manner in which we check if the job is a silo is by using a new
jobobject information class with QueryInformationJobObject that fails
unless the job is a silo.