Add CI stage dependencies #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize CI to run in stages, so lint and protobuild are dependencies for vendoring, which in turn is required for testing then building. This allows issues to be caught early on, and prevents long-running test stages to run before lint or vendor issues fail CI. Ran YML formatter on ci.yml file. Added `if` condition to uploading test binary artifices for non PR runs, to avoid unnecessary uploading and storage. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Github branch protection is confused by names, so remove them Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
|
|
||
| build: | ||
| runs-on: 'windows-2019' | ||
| needs: [test, integration-tests] |
There was a problem hiding this comment.
would we want this to be before the tests?
There was a problem hiding this comment.
Since the only thing this job does is publish artifacts, i figured they only be uploaded if tests pass
I am not sure what else this stage would get us, since if the binaries dont compile, the test jobs would fail as well
anmaxvl
approved these changes
Jul 11, 2022
dcantah
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize CI to run in stages, so lint and protobuild are dependencies
for vendoring, which in turn is required for testing then building.
This allows issues to be caught early on, and prevents long-running
test stages to run before lint or vendor issues fail CI.
Ran YML formatter on ci.yml file.
Added
ifcondition to uploading test binary artifices for non PRruns, to avoid unnecessary uploading and storage.
Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com