-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcs: Support routing container stdio to sidecar #1728
Conversation
Hey Ashish, I think this is a reasonable way to approach this for a prototype, but does not achieve the level of integration with the existing codebase that we are looking for to merge. I don't have time to dig into the design here personally right now, but I think the following things would be good to look into:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ashish,
Please review the comments I left on the PR. We will get another reviewer to take a look, and then merge this once everything looks good. I want to note we are merging this to enable initial testing with this feature, and that we will need to revisit the design of the feature in the future.
A few other things to address:
- Please rebase into a single commit, with a good title and descriptive commit message.
- Sign your commit with
git commit -s
. - Sign the CLA (see the bot's comment) when you get a chance.
aaca850
to
3fab6e3
Compare
@microsoft-github-policy-service agree company="Microsoft" |
de03589
to
3f421f8
Compare
Signed-off-by: Ashish Sachdeva <asachdev@microsoft.com>
9592219
to
b1b0768
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR updates our ADO fork to commits in hcsshim up to commit hash [7769a64](7769a64). This includes support for partitioned scsi devices and ensuring filesystem format for lcow scsi devices. Related work items: #1728, #1740, #1741, #1742, #1743, #1744, #1745, #1747, #1748, #1749, #1750, #1752, #1754, #1756, #1757, #1767, #1769, #1771, #1772, #1773, #1779
The PR aims to add support for redirecting container stdout and stderr statements to a another container(logging container) via named pipes.
This is controlled by set of annotations being passed in the spec.
When the annotation is set, the named pipe is created in the UVM. The workload container will start to redirect stdout and stderr statements to this named pipe and logging container will use the pipe file descriptor passed to it to read data coming through pipe.