Remove UVM/container cloning functionality #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2023
katiewasnothere
approved these changes
Apr 24, 2023
|
@ambarve could you PTAL? |
This change completely removes the support for cloning/late cloning that was added a few years ago. The reasoning behind this is as follows: - There are no plans to utilize cloning at this point in time. - The cloning support required extensive/invasive changes across many parts of the shim. This has made future changes and refactorings more difficult in some cases. While these changes are still possible, it seems like an unnecessary burden if we are not going to use cloning. - The cloning functionality was never actually utilized, and thus may still have had fixes needed to be production-ready. If cloning is needed again in the future, we will be able to revert this commit to add it back. Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
anmaxvl
approved these changes
Apr 25, 2023
msscotb
approved these changes
May 2, 2023
|
CI failures are not related. |
Merged
anmaxvl
pushed a commit
that referenced
this pull request
Oct 20, 2023
This PR updates our ADO fork to commits in hcsshim up to commit hash [7769a64](7769a64). This includes support for partitioned scsi devices and ensuring filesystem format for lcow scsi devices. Related work items: #1728, #1740, #1741, #1742, #1743, #1744, #1745, #1747, #1748, #1749, #1750, #1752, #1754, #1756, #1757, #1767, #1769, #1771, #1772, #1773, #1779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is commit 1/6 in a chain. Recommended to review in order. If reviewing a later PR in the chain, you can view individual commits to see just what that PR changes.
This change completely removes the support for cloning/late cloning that was added a few years ago. The reasoning behind this is as follows:
If cloning is needed again in the future, we will be able to revert this commit to add it back.