slice bounds and nil VM access fix #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+68
to
+71
| if vm == nil { | ||
| return "", "", nil, errors.New("MountLCOWLayers cannot be called for process-isolated containers") | ||
| } | ||
|
|
There was a problem hiding this comment.
Does this happen in the tests? :o
There was a problem hiding this comment.
no, but i figured it'd make it match MountWCOWLayers, and better safe than sorry 😅
katiewasnothere
approved these changes
May 4, 2023
anmaxvl
approved these changes
May 4, 2023
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
pushed a commit
that referenced
this pull request
Oct 20, 2023
This PR updates our ADO fork to commits in hcsshim up to commit hash [7769a64](7769a64). This includes support for partitioned scsi devices and ensuring filesystem format for lcow scsi devices. Related work items: #1728, #1740, #1741, #1742, #1743, #1744, #1745, #1747, #1748, #1749, #1750, #1752, #1754, #1756, #1757, #1767, #1769, #1771, #1772, #1773, #1779
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.