-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create types for untyped nodes #177
Create types for untyped nodes #177
Conversation
I've made changes in kiota-serialization-json-dotnet, but need to reference kiota-abstractions-dotnet 1.7.6 before creating a pull request. Suppose that at the end, the SDK generator will generate something like this
instead of the current:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, a couple of remarks. I think you can implement the POC with a local reference for the json serialization and see how that turns out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment on this side.
Otherwise, we need a version bump to 1.8.0 as well as a changelog entry.
69066a1
to
8f471e8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
53837af
to
c14a532
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Conflicts have been resolved. A maintainer will take a look shortly. |
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
# Conflicts: # CHANGELOG.md # src/Microsoft.Kiota.Abstractions.csproj
Just as an update to anyone watching this: we're finalizing the work on the other main languages before we merge everything in. Thank you for your patience :) |
Closes #175