Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

size reduction: deduplicate error mappings #4025

Closed
baywet opened this issue Jan 18, 2024 · 0 comments · Fixed by #4135
Closed

size reduction: deduplicate error mappings #4025

baywet opened this issue Jan 18, 2024 · 0 comments · Fixed by #4135
Assignees
Labels
enhancement New feature or request generator Issues or improvements relater to generation capabilities. WIP
Milestone

Comments

@baywet
Copy link
Member

baywet commented Jan 18, 2024

We have an opportunity to reduce the size of the projected SDKs, especially in the context of Microsoft Graph.
For a lot of APIs, the schema for the error responses, is the same across the error codes:

  • Microsoft Graph describes ODataError for both 4XX and 5XX
  • A lot of APIs use the default mapping for errors

Right now we project both those cases to two entries (4XX and 5XX), while it works it's wasteful.

  • In the case of default, we could map things to a single XXX entry,
  • In the case where we have only 4XX and 5XX, and both codes map to the same schema, we could reduce that to a single XXX entry.

This will require updating the request adapter implementations first to account for that special status code across languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request generator Issues or improvements relater to generation capabilities. WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants