Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a new API description, Kiota should load with no pre-selected endpoints #4854

Closed
maisarissi opened this issue Jun 18, 2024 · 4 comments
Assignees
Labels
type:bug A broken experience vscode-extension Work related to the vscode-extension
Milestone

Comments

@maisarissi
Copy link
Contributor

After creating an API Plugin/client for an specific API, one might want to create another API Plugin/client for the same API but with different endpoints.
So every time a user adds a new API description, even if it's the same OpenAPI description that was load before, Kiota should load the API explorer with no selected paths.

Today, after generating an API Plugin/client, if I try to add the same OpenAPI description to create something different, Kiota loads the previous selected paths.

@maisarissi maisarissi added type:bug A broken experience status:waiting-for-triage An issue that is yet to be reviewed or assigned vscode-extension Work related to the vscode-extension labels Jun 18, 2024
@baywet baywet added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Jun 18, 2024
@baywet
Copy link
Member

baywet commented Jun 18, 2024

@maisarissi I think this perception is biased by the fact you're running a lot of demonstrations. Arguably the answer to "are people more likely to generate more clients/plugins with fewer endpoints, or more likely to edit existing plugins/clients?" depends on the kind of work you're doing.
In my experience, unless there are different authentication requirements, or unless the user is working with multiple languages in the same project, it's usually more of a matter of adding something they were missing after generating.

@maisarissi
Copy link
Contributor Author

I agree with you @baywet . It's more likely that one would want to edit/add something they were missing after generating and this will be done by the "edit paths" scenario, when one is editing the workspace file.
However, after generating, if one tries to add the same API using the "Add API description", which is to create a whole new thing, we should load Kiota with no pre-selected endpoints.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 and removed status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close labels Jun 18, 2024
@baywet
Copy link
Member

baywet commented Jun 18, 2024

Ah I didn't get the fact this was specifically for the "add API description" flow, not just the auto-reload after generating. Thanks for the precision.

@baywet baywet modified the milestones: Backlog, Kiota v1.16 Jun 18, 2024
@ElinorW ElinorW self-assigned this Jun 19, 2024
@ElinorW
Copy link
Contributor

ElinorW commented Jun 26, 2024

Closing this as it was been resolved

@ElinorW ElinorW closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A broken experience vscode-extension Work related to the vscode-extension
Projects
Archived in project
Development

No branches or pull requests

3 participants