Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create additional integration tests for remaining env variables #19

Closed
JimPaine opened this issue May 27, 2021 · 0 comments · Fixed by #20
Closed

Create additional integration tests for remaining env variables #19

JimPaine opened this issue May 27, 2021 · 0 comments · Fixed by #20
Assignees
@JimPaine
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.9.0

Comments

@JimPaine
Copy link
Member

#17 showed that on main the ability to set the template via an env variable was broken, this has been fixed in #18 but we could add additional integration tests to ensure that other env variables are not impacted in the future.
@JimPaine JimPaine added the enhancement New feature or request label May 27, 2021
@JimPaine JimPaine added this to the v0.9.0 milestone May 27, 2021
@JimPaine JimPaine added the good first issue Good for newcomers label May 27, 2021
@JimPaine JimPaine self-assigned this Sep 10, 2021
@JimPaine JimPaine mentioned this issue Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimPaine JimPaine

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

added additional int tests microsoft/lignator
1 participant
@JimPaine