New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an integrated, light weight way to chat with VS Live Share participants in a collaboration session #69
Comments
I would add that quoting the code or anchoring the line from the chat would be helpful as the inline comments are also meant to be contextual. |
I'd also like a way to @ mention a specific collaborator and/or have him be visibly (and/or audibly) pinged by me. Thank you so much for the work so far |
Bookmarking a line or committing on the line will work?? 🤔 |
@gokulkrishh @jacquesfu Yeah that's an interesting point. Would you see a feature along these lines as more akin to "real-time commenting" rather than what we'd classically consider "chat"? Something that would allow you to annotate lines/files,etc in context? |
@Chuxel do you mean something more akin to google doc comments (highlighting a section and leaving a note) vs something like slack (message can be anything, even if it is unrelated to the code)? |
@IkeKap Yeah basically (whether that's the specific UX or not is a separate question of course). The thought is, given most people we have multiple chat systems they're already dealing with, giving a more focused experience could supplement those chat systems in a more meaningful way. We could then think of a way to "summon" people like #73 and we already have pin/follow. Does that make sense? |
Just gave this extension a test run. Love it! And totally agree, an in-editor chat would be extremely useful, with the ability to include a direct link to a line of code in any file. |
As an FYI, the folks at CodeStream are working on VS Code support for their integrated developer chat experience, which also includes integration with Live Share (e.g. creating session-specific channels when you share). I'd definitely recommend checking them out, and letting us know how well it suits your use cases. We're pretty excited about what they demonstrated at Build this week 👍 |
Confirm merge from repo_sync_working_branch to live to sync with https://github.com/microsoftdocs/live-share (branch master)
For those already on Slack - you can use the vscode-chat extension to send and receive messages inside VS Code Disclaimer: I'm the author of the extension. I was looking for an easier way to collaborate across VS Code and Slack, and thought I could just build one :) |
@arjun27 Very cool! Is that published to the marketplace yet? There are other Slack integrations for VS Code, but none (that I know of) that used a web view. |
Glad you liked it @lostintangent. Yup, it's on the marketplace. It's very early (just released it yesterday), so there might be some issues. Feel free to report them! :)
Yup, I couldn't find one with a web view either. There are a few that let you send messages via text input, but I really wanted a way to receive messages too, and using a web view made a ton of sense. |
In case come folks didn’t see it, we shipped an extension that allows starting up a voice chat as part of a Live Share session: VS Live Share Audio. We’d love any and all feedback on it. Between this, the aforementioned Slack Chat extension (assuming it adds Teams support soon 😄 ), and the upcoming CodeStream support for VS Code, I’d love to hear how well those solve folks needs for chat. Additionally, to address communication that is a little more async/non-disruptive, there are three other things we’re exploring:
Does any of that sound interesting? Would folks still need a real-time, integrated text chat, that wasn’t backed by an existing chat solution (e.g. Slack, Teams, CodeStream)? |
hi, CEO of CodeStream here. thanks for the callout @lostintangent. please forgive the shameless plug; just providing a TL;DR of what we do in case anyone is interested. codestream is a somewhat ambitious franken-plugin that tries to do two main things:
it works a lot like the comment system in google docs. if anyone is interested in trying out a beta version of codestream for vs code please ping me at pez@codestream.com -- should be ready in about two weeks. |
Just wanted to say that the voice chat work is great 👍 I think for me the inline comments which are accessible in a historical context so you can jump between them quickly fits how I'd imagine using text-chat. |
Yep, that's what I had I mind 👍 |
Quick update on the chat extension: you can now chat with participants of a collaboration session without using a backend like Slack. This is built over the Live Share RPC, and does not require any additional steps after starting a session. Optionally, you can sign in with Slack/Discord in case you want to use an existing chat account. |
It's a shame the chat extension doesn't work for me. The input box just says "Message undefined" and nothing works. |
Hey everyone! So I'm going to close this issue as resolved for the following reasons:
So with all of the above in mind, I'd love to close this issue, and then we can track gaps/etc. that are missing, and how we can best address them via new targeted issues. Thanks again for all the great feedback! |
FYI folks, CodeStream just released an extension for VS, so there is now an integrated chat experience for both VS and VS Code 👍 https://marketplace.visualstudio.com/items?itemName=CodeStream.codestream-vs |
@lostintangent was this feature removed? Can't seem to figure out how to get collaborative comments with Live Share (latest VS Code 1.33.1 or Insiders and Live Share 1.0.182) |
Its strange because I cant see the comments feature either. I also cant see chat, but my buddy who I am sharing with has chat. I have found no thread or forum to how how to enable this feature or why I wouldnt have it. |
I installed the "Team Chat: for Slack, Discord and Live Share" extension. However like others I am getting the 'Message undefined' symptom. And trying to invite to live share thows another error: |
@x30n @GreggOD Unfortunately, the inline code comments experience had to be removed due to a change in VS Code that broke it for Live Share. However, we'll be releasing an update to Live Share today that introduces it back. For now, it will only work in VS Code Insiders. I'll update this thread as soon as the update is released! CC @arjun27 for the Team Chat issue. We've seen this issue before, but we thought we resolved it :/ |
@lostintangent Nice work. Thanks for your efforts in making developers lives easier.. and for nothing in return. Bless you. |
@lostintangent please kindly reopen the issue. Thanks. |
the chat worked just fine when i was was doing it before but then i did it with another person then it says "The chat service is currently disconnected. Please try again shortly." |
i tried to reinstall extensions but i still cant use chat |
While most developers that collaborate will be using an existing chat solution (Slack, Teams, Skype, etc), hands on use has indicated that command/alt-tabbing is pretty distracting. In addition, it does not immediately grab your attention if someone is trying to communicate with you. While voice conversations work really well (see #22) and do not suffer from these problems, modern team room environments sometimes preclude its use.
Consequently, we have seen hosts and guests have often use temporary comments or text to make quick comments while editing which points out a gap.
VS Live Share extensions could introduce a light weight chat mechanism to allow participants in the collaboration session to communicate in context. This would not be a replacement for broader chat systems but instead complements them for this use case.
Give an up-vote reaction (👍) if you would like to see this added. Sound off below if you have other thoughts.
The text was updated successfully, but these errors were encountered: