Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeError: 'lora.Conv2d' object has no attribute 'weight' #134

Closed
bjzhb666 opened this issue Oct 7, 2023 · 3 comments
Closed

AttributeError: 'lora.Conv2d' object has no attribute 'weight' #134

bjzhb666 opened this issue Oct 7, 2023 · 3 comments

Comments

@bjzhb666
Copy link

bjzhb666 commented Oct 7, 2023 •
edited
Loading

Thanks for your great work!

When I use loralib-0.1.2, I get this error.
In nn.Conv2d, it has the attribute 'weight'.
I think it is better to add weight attribute to our lora.Conv2d.

It is interesting that in version loralib-0.1.1, lora.Conv2d has this attribute, but in the latest version, my code gives me this bug.

Tasks
Beta Give feedback
No tasks being tracked yet.
@RasmusD
Copy link

RasmusD commented Oct 17, 2023

It's because of this PR: #63

@edwardjhu
Copy link
Collaborator

Good catch. It's now self.conv.weight.

@bjzhb666
Copy link
Author

Thanks for your replies!

@EricTan7 EricTan7 mentioned this issue Mar 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RasmusD @edwardjhu @bjzhb666