Create user fails on macOS 10.13 - "Failed to authenticate with SystemAdministration framework."

[americanhanko]

================================================================================
           Error executing action `create` on resource 'macos_user[create admin user randall and enable automatic login]'
           ================================================================================

           Mixlib::ShellOut::ShellCommandFailed
           ------------------------------------
           execute[add user randall] (/tmp/kitchen/cache/cookbooks/macos/resources/macos_user.rb line 48) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '255'
           ---- Begin output of ["/usr/sbin/sysadminctl", "-addUser", "randall", "", "-password", "correct-horse-battery-staple", "-admin"] ----
           STDOUT:
           STDERR: 2018-01-25 11:17:50.480 sysadminctl[880:5142] Failed to authenticate with SystemAdministration framework.
           ---- End output of ["/usr/sbin/sysadminctl", "-addUser", "randall", "", "-password", "correct-horse-battery-staple", "-admin"] ----
           Ran ["/usr/sbin/sysadminctl", "-addUser", "randall", "", "-password", "correct-horse-battery-staple", "-admin"] returned 255

           Resource Declaration:
           ---------------------
           # In /tmp/kitchen/cache/cookbooks/macos_test/recipes/new_users.rb

             1: macos_user 'create admin user randall and enable automatic login' do
             2:   username 'randall'
             3:   password 'correct-horse-battery-staple'
             4:   autologin true
             5:   admin true
             6: end
             7:

[americanhanko]

When running sysadminctl on 10.13, the admin user and password need to be passed to sysadminctl in addition to the -addUser options.

Changes to the sysadminctl command can be seen in the usage output on each OS:

macOS 10.12.6

Usage: sysadminctl
	-deleteUser <user name> [-secure || -keepHome]
	-newPassword <new password> -oldPassword <old password> [-passwordHint <password hint>]
	-resetPasswordFor <local user name> -newPassword <new password> [-passwordHint <password hint>]
	-addUser <user name> [-fullName <full name>] [-UID <user ID>] [-shell <path to shell>] [-password <user password>] [-hint <user hint>] [-home <full path to home>] [-admin] [-picture <full path to user image>]
	-guestAccount <on || off || status>
	-afpGuestAccess <on || off || status>
	-smbGuestAccess <on || off || status>

Pass '-' instead of password in commands above to request prompt.

macOS 10.13.2

Usage: sysadminctl [[interactive] || [-adminUser <admin user name> -adminPassword <admin user password>]]
	-deleteUser <user name> [-secure || -keepHome]
	-newPassword <new password> -oldPassword <old password> [-passwordHint <password hint>]
	-resetPasswordFor <local user name> -newPassword <new password> [-passwordHint <password hint>]
	-addUser <user name> [-fullName <full name>] [-UID <user ID>] [-shell <path to shell>] [-password <user password>] [-hint <user hint>] [-home <full path to home>] [-admin] [-picture <full path to user image>]
	-secureTokenStatus <user name>
	-secureTokenOn <user name> -password <password>
	-secureTokenOff <user name> -password <password>
	-guestAccount <on || off || status>
	-afpGuestAccess <on || off || status>
	-smbGuestAccess <on || off || status>
	-automaticTime <on || off || status>
	-filesystem status
Pass '-' instead of password in commands above to request prompt.

[americanhanko]

Resolved via #33