Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Contrast PointerOver and Pressed colors do not work in HyperlinkButton #419

Closed
dannyp32 opened this issue Mar 13, 2019 · 5 comments
Closed
Labels
bug Something isn't working needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) no-issue-activity team-Controls Issue for the Controls team

Comments

@dannyp32
Copy link

Describe the bug

When I have a textblock inside of a hyperlink button in high contrast mode, the color doesn't change when I hover over it or click on it.

    <HyperlinkButton>
        <TextBlock Text="hello"></TextBlock>
    </HyperlinkButton>

Expected behavior

PointerOver and Pressed states should change the color of the text in high contrast mode.

Screenshots

image

Version Info

NuGet package version:

Windows 10 version Saw the problem?
Insider Build (xxxxx)
October 2018 Update (17763) Yes
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Anniversary Update (14393)
Device form factor Saw the problem?
Desktop Yes
Mobile
Xbox
Surface Hub
IoT

Additional context

@msft-github-bot msft-github-bot added this to Needs triage in Controls Triage Mar 13, 2019
@jevansaks
Copy link
Member

Does it work if you don't use TextBlock but just set <HyperlinkButton Content="hello"/>?

@jevansaks
Copy link
Member

Nevermind, I set up the repro and see it for both. Very odd. We'll take a look.

@jevansaks jevansaks added the bug Something isn't working label Mar 14, 2019
@jevansaks jevansaks moved this from Needs triage to Approved in Controls Triage Mar 14, 2019
@jevansaks
Copy link
Member

We also had an internal issue tracking this as well.

@jevansaks jevansaks changed the title High Contrast PointerOver and Pressed colors do not work for a TextBlock inside a HyperLinkButton High Contrast PointerOver and Pressed colors do not work in HyperLinkButton Mar 14, 2019
@jevansaks jevansaks changed the title High Contrast PointerOver and Pressed colors do not work in HyperLinkButton High Contrast PointerOver and Pressed colors do not work in HyperlinkButton Mar 14, 2019
@marcelwgn
Copy link
Contributor

I think this issue can only be adressed with WinUI 3.0, since the HyperlinkButton has no files in the WinUI repository currently.

@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
@jevansaks jevansaks added the needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) label Nov 22, 2019
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) no-issue-activity team-Controls Issue for the Controls team
Projects
No open projects
Development

No branches or pull requests

3 participants