Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup Overlay Incorrect in Scale/Transform Scenarios -- Regression after 1.3.230724000 #9433

Closed
cwhitlatch opened this issue Mar 13, 2024 · 1 comment
Labels
area-Popup bug Something isn't working team-Controls Issue for the Controls team
Milestone

Comments

@cwhitlatch
Copy link

Describe the bug

If a parent container of a Popup implements a transform or changes scale, the overlay ignores and does not adjust size. Mouse over and click behavior will also be incorrect. The root issue appears to be a regression when ShouldConstrainToRootBounds was introduced. 1.3.230724000 and earlier work properly and overlay content is scaled/located correctly.

Sample app demonstrating the issue: PopupSizeIssue.zip

Steps to reproduce the bug

Wrap a combobox within a LayoutTransformControl with scaling applied.

Sample App: PopupSizeIssue.zip

Expected behavior

Popup overlay should be sized properly to the scale/transform applied.

Screenshots

Using Live Visual Tree will show the PopupBorder being sized correctly and the overlay being incorrect:
image

From the sample app, the incorrect layout:
image

And the correct layout if running 1.3.230724000 or earlier:
image

NuGet package version

WinUI 3 - Windows App SDK 1.5.1: 1.5.240311000

Windows version

Windows 11 (22H2): Build 22621

Additional context

All Popups exhibit this issue, regardless of where they are defined. ShouldConstrainToRootBounds True/False both exhibit the issue.

@cwhitlatch cwhitlatch added the bug Something isn't working label Mar 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Mar 13, 2024
@bpulliam bpulliam added team-Controls Issue for the Controls team area-Popup and removed needs-triage Issue needs to be triaged by the area owners labels Mar 14, 2024
@gegao18
Copy link

gegao18 commented Mar 25, 2024

Thanks for reporting this. We have a fix for this issue in WASDK 1.5.2.

Here's what I see in the repro app now:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Popup bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

4 participants