Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to replace/update the bundled TS language service #1426

Closed
ulrichb opened this issue Apr 24, 2019 · 2 comments
Closed

Allow to replace/update the bundled TS language service #1426

ulrichb opened this issue Apr 24, 2019 · 2 comments
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)

Comments

@ulrichb
Copy link
Contributor

ulrichb commented Apr 24, 2019

This is a follow-up of #177.

Same issue, but now with the Monaco Editor-bundled version 3.3 (without e.g. readonly tuples feature) vs. current version 3.4.

Is there a possibility to use the TypeScript language service (typescriptServices.js) from the typescript npm package instead of the bundled one (.../monaco-editor/esm/vs/language/typescript/lib/typescriptServices.js) without forking Monaco Editor?

@ulrichb
Copy link
Contributor Author

ulrichb commented May 21, 2019

@alexandrudima Is there any possibility? I'm really struggling with the semantic model errors when using TS 3.4 declarations containing readonly tuples and arrays...

... if there is no (easy) possiblity ... when can expect a Monaco Editor release containing TS 3.4 (or 3.5)?

@alexdima
Copy link
Member

It is possible to fork monaco-typescript and publish it to npm as monaco-typescript-fork. Then, it is possible to fork this project and tweak the monaco-typescript plugin section here --

{
name: 'monaco-typescript',
contrib: 'vs/language/typescript/monaco.contribution',
modulePrefix: 'vs/language/typescript',
thirdPartyNotices: 'node_modules/monaco-typescript/ThirdPartyNotices.txt',
paths: {
src: '/monaco-typescript/release/dev',
'npm/dev': 'node_modules/monaco-typescript/release/dev',
'npm/min': 'node_modules/monaco-typescript/release/min',
esm: 'node_modules/monaco-typescript/release/esm',
}
},

You can then execute gulp release and you will get a monaco editor built with your custom monaco-typescript.

@alexdima alexdima added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Dec 11, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants