Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-gyp to peerDependencies #505

Closed
daniel-brenot opened this issue Oct 30, 2021 · 3 comments
Closed

Add node-gyp to peerDependencies #505

daniel-brenot opened this issue Oct 30, 2021 · 3 comments
Milestone

Comments

@daniel-brenot
Copy link
Contributor

Environment details

  • OS: Mac Os
  • OS version: 11.6
  • node-pty version:

Issue description

When trying to install dependencies for the theia IDE, I get the following message:

# Script name: install

Usage Error: Couldn't find a script name "node-gyp" in the top-level (used by @theia/node-pty@npm:0.9.0-theia.6). This typically happens because some package depends on "node-gyp" to build itself, but didn't list it in their dependencies. To fix that, please run "yarn add node-gyp" into your top-level workspace. You also can open an issue on the repository of the specified package to suggest them to use an optional peer dependency.

$ yarn run [--inspect] [--inspect-brk] [-T,--top-level] [-B,--binaries-only] <scriptName> ...```

## Issue Solution

Add node-gyp to the peer dependencies for the project
@valeriangalliat
Copy link

I'm running into this issue as well.

Looks like #567 introduced a regression by removing the node-gyp dependency.

@Tyriar
Copy link
Member

Tyriar commented Mar 14, 2023

@valeriangalliat it's not meant to be required now according to #567? cc @deepak1556, @rzhao271

@valeriangalliat
Copy link

Oh that's right. Looks like node-pty@0.10.1 (latest) on npm still has that install script in package.json somehow! https://socket.dev/npm/package/node-pty/files/0.10.1/package.json#L39 That would explain why this error still happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants